Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5877: Editors can create anchor links to Colorbands #1653

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Oct 14, 2024

READY FOR REVIEW

Summary

  • Adds an id to the container of colorband paragraphs

Need Review By (Date)

10/23

Urgency

medium

Steps to Test

  1. Visit a page with "Colorband" components (or create a new one). You can use one of the following:
  2. Inspect the page source code and search for ptype-hs-clr-bnd. This class is added to the colorband component wrapper div. You should also see in the div an id with the format component-XYZ (where XYZ is a unique numerical ID):
    Screenshot 2024-10-15 at 11 43 25 AM
  3. Visit any other flexible page and search for other types of components. Confirm that the id is not present in any case. You can search for ptype- to find the component wrapper div elements.

PR Checklist


@cienvaras cienvaras self-assigned this Oct 14, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat October 14, 2024 18:28 Destroyed
@cienvaras cienvaras marked this pull request as ready for review October 15, 2024 17:54
@cienvaras cienvaras assigned ahughes3 and unassigned cienvaras Oct 15, 2024
@cienvaras cienvaras requested a review from ahughes3 October 15, 2024 17:54
@cienvaras
Copy link
Collaborator Author

@ahughes3 Ready for you to review.

Base automatically changed from 11.3.1-release to develop October 16, 2024 15:43
@ahughes3 ahughes3 temporarily deployed to Tugboat October 17, 2024 15:13 Destroyed
@cienvaras cienvaras changed the base branch from develop to 11.4.1-release October 17, 2024 15:33
@ahughes3 ahughes3 temporarily deployed to Tugboat October 21, 2024 19:16 Destroyed
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 requested a review from joegl October 21, 2024 21:05
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 21, 2024
@joegl joegl merged commit 8060c48 into 11.4.1-release Oct 22, 2024
17 of 18 checks passed
@joegl joegl deleted the shs-5877--add-collorband-ids branch October 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants