Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSD8-000: Add phpcs (Drupal PHP CodeSniffer) to CI #1686

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

joegl
Copy link
Contributor

@joegl joegl commented Nov 19, 2024

READY FOR REVIEW

Summary

[briefly summarize the changes here]

Need Review By (Date)

['10/30', 'asap', etc.]

Urgency

['low', 'medium', 'high', etc.]

Steps to Test

  1. [First testing step]
  2. ...

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 20:10 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 20:49 Destroyed
Copy link
Collaborator

@dalin- dalin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

phpcs.dist.xml Outdated Show resolved Hide resolved
phpcs.dist.xml Outdated Show resolved Hide resolved
@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 21:21 Destroyed
@joegl
Copy link
Contributor Author

joegl commented Nov 19, 2024

Some suggestions.

Thanks @dalin- 👍

@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 21:22 Destroyed
Base automatically changed from HSD8-1664--update-pr-template to 11.6.1-release December 19, 2024 16:02
Base automatically changed from 11.6.1-release to develop January 8, 2025 16:39
@joegl joegl changed the base branch from develop to 11.6.4-release January 30, 2025 18:28
@ahughes3 ahughes3 temporarily deployed to Tugboat January 30, 2025 21:22 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 30, 2025 21:24 Destroyed
@joegl
Copy link
Contributor Author

joegl commented Jan 30, 2025

I'm going to merge this even though it's failing. We can clean-up the code as needed and time permitting and this won't be a required check for merging, but it will be nice to have.

@joegl joegl merged commit 4a2836f into 11.6.4-release Jan 30, 2025
13 of 16 checks passed
@joegl joegl deleted the HSD8-000--add-phpcs-ci branch January 30, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants