Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSD8-687: Slow stage sites #1714

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

sethprime
Copy link
Contributor

Summary

Resolves deprecated function debug notices from H&S Field Helpers and H&S Layouts. Patches the Shield module to resolve warnings in the Watchdog logs.

Need Review By (Date)

Urgency

Low

Steps to Test

  1. [First testing step]
  2. ...

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@ahughes3 ahughes3 temporarily deployed to Tugboat January 10, 2025 19:49 Destroyed
@sethprime sethprime requested a review from pookmish January 10, 2025 19:53
@ahughes3 ahughes3 temporarily deployed to Tugboat January 13, 2025 20:00 Destroyed
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pookmish pookmish merged commit 17ffc0f into 11.6.3-release Jan 13, 2025
16 of 17 checks passed
@pookmish pookmish deleted the HSD8-1687-review-slow-stage-sites branch January 13, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants