-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSD8-1577 | Remove D7 unused importers #1720
Merged
pookmish
merged 5 commits into
11.6.4-release
from
HSD8-1577--remove-d7-importers-from-sites
Jan 23, 2025
Merged
HSD8-1577 | Remove D7 unused importers #1720
pookmish
merged 5 commits into
11.6.4-release
from
HSD8-1577--remove-d7-importers-from-sites
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pookmish
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small tweaks needed. Otherwise this is a good approach.
…n outside the importer loop, and cleaned up the if statement logic.
pookmish
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the requested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an update hook to remove unused D7 content importers in hs_migrate, and removes their config files.
Importer status: https://docs.google.com/spreadsheets/d/1-mQg46wHXhqXQUPkzPXD_OFtSb8_OOq8NszVafL3LwA
Need Review By (Date)
Urgency
Low
Steps to Test
Review Tasks
Backend / Functional Validation
Code
snake_case
and notcamelCase
?Code security
General