Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSD8-1577 | Remove D7 unused importers #1720

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

sethprime
Copy link
Collaborator

Summary

Adds an update hook to remove unused D7 content importers in hs_migrate, and removes their config files.

Importer status: https://docs.google.com/spreadsheets/d/1-mQg46wHXhqXQUPkzPXD_OFtSb8_OOq8NszVafL3LwA

Need Review By (Date)

Urgency

Low

Steps to Test

  1. Pull changes.
  2. Run the database update.
  3. Verify that the importers are removed.

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@sethprime sethprime requested a review from pookmish January 17, 2025 17:05
@ahughes3 ahughes3 temporarily deployed to Tugboat January 17, 2025 17:05 Destroyed
@ahughes3 ahughes3 requested a review from joegl January 21, 2025 22:32
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small tweaks needed. Otherwise this is a good approach.

docroot/modules/humsci/hs_migrate/hs_migrate.install Outdated Show resolved Hide resolved
docroot/modules/humsci/hs_migrate/hs_migrate.install Outdated Show resolved Hide resolved
docroot/modules/humsci/hs_migrate/hs_migrate.install Outdated Show resolved Hide resolved
docroot/modules/humsci/hs_migrate/hs_migrate.install Outdated Show resolved Hide resolved
Base automatically changed from 11.6.3-release to develop January 22, 2025 16:25
…n outside the importer loop, and cleaned up the if statement logic.
@ahughes3 ahughes3 temporarily deployed to Tugboat January 22, 2025 20:27 Destroyed
@sethprime sethprime requested a review from pookmish January 22, 2025 21:51
@pookmish pookmish changed the base branch from develop to 11.6.4-release January 23, 2025 16:06
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the requested changes.

@pookmish pookmish enabled auto-merge (squash) January 23, 2025 16:08
@pookmish pookmish merged commit 7383fdc into 11.6.4-release Jan 23, 2025
17 of 18 checks passed
@pookmish pookmish deleted the HSD8-1577--remove-d7-importers-from-sites branch January 23, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants