-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5978: Site Dashboard: Missing Alt Text #1722
Open
callinmullaney
wants to merge
8
commits into
SHS-5913_Dashboard-initiative
Choose a base branch
from
shs-5978
base: SHS-5913_Dashboard-initiative
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpose decorative value in views
@ahughes3 Ready for your review. |
@ahughes3 Updated the PR to add the table header, as discussed in today's demo: ![]() |
…humsci into shs-5978
@ahughes3 PR updated with a default dashboard exported for testing, no need to manually create the dashboard and add the block anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Need Review By (Date)
TBD
Urgency
low
Steps to Test
Note 1: The "decorative" checkbox in the images is just an UI element that hides the Alt text field, selecting it doesn't store any information in the database. For this reason is not possible to filter the "decorative" images from "regular" images without alt text.
Note 2: Dashboard and block styles are implemented in another PR. Those styles will be applied to this block when everything is merged together in the Dashboard Initiative branch.
Review Tasks
Backend / Functional Validation
Code
snake_case
and notcamelCase
?Code security
General