Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5978: Site Dashboard: Missing Alt Text #1722

Open
wants to merge 8 commits into
base: SHS-5913_Dashboard-initiative
Choose a base branch
from

Conversation

callinmullaney
Copy link
Collaborator

@callinmullaney callinmullaney commented Jan 21, 2025

Summary

  • Extends the existing alt text view with a new block display. This block display lists the 5 most recent images that are missing alt text.

Need Review By (Date)

TBD

Urgency

low

Steps to Test

  1. Visit the dashboard page and confirm that you can see the "Missing Alt Text" block and that it matches the AC in the ticket

Note 1: The "decorative" checkbox in the images is just an UI element that hides the Alt text field, selecting it doesn't store any information in the database. For this reason is not possible to filter the "decorative" images from "regular" images without alt text.

Note 2: Dashboard and block styles are implemented in another PR. Those styles will be applied to this block when everything is merged together in the Dashboard Initiative branch.

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@ahughes3 ahughes3 temporarily deployed to Tugboat January 27, 2025 20:39 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 27, 2025 21:15 Destroyed
@cienvaras
Copy link
Collaborator

@ahughes3 Ready for your review.

@cienvaras cienvaras requested a review from ahughes3 January 27, 2025 21:51
@cienvaras cienvaras assigned ahughes3 and unassigned cienvaras Jan 27, 2025
@cienvaras cienvaras changed the title shs-5978: Site Dashboard: Missing Alt Text SHS-5978: Site Dashboard: Missing Alt Text Jan 27, 2025
@ahughes3 ahughes3 temporarily deployed to Tugboat January 28, 2025 22:20 Destroyed
@cienvaras
Copy link
Collaborator

@ahughes3 Updated the PR to add the table header, as discussed in today's demo:

Screenshot 2025-01-28 at 4 17 30 PM

@ahughes3 ahughes3 temporarily deployed to Tugboat February 3, 2025 15:35 Destroyed
@cienvaras
Copy link
Collaborator

@ahughes3 PR updated with a default dashboard exported for testing, no need to manually create the dashboard and add the block anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants