-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional parameters must be passed by name #1307
Merged
lars-reimann
merged 10 commits into
main
from
1163-specify-optional-parameters-by-name-only
Jan 8, 2025
Merged
feat: optional parameters must be passed by name #1307
lars-reimann
merged 10 commits into
main
from
1163-specify-optional-parameters-by-name-only
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
========================================
Coverage 99.72% 99.72%
========================================
Files 113 118 +5
Lines 12783 12905 +122
Branches 4199 4229 +30
========================================
+ Hits 12748 12870 +122
Misses 35 35 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1163
Summary of Changes
Optional parameters must now be passed by name. This allows reordering them in the stubs and inserting new optional parameters anywhere instead of just at the end. We can now also deprecate all optional parameters without introducing a new function.
The error has an associated quickfix (our first). This PR also adds a data-driven test system for quickfixes and other code actions.