Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure plotting methods #62

Closed
lars-reimann opened this issue Mar 22, 2023 · 1 comment · Fixed by #88
Closed

Restructure plotting methods #62

lars-reimann opened this issue Mar 22, 2023 · 1 comment · Fixed by #88
Assignees
@lars-reimann
Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

The interface of plotting methods is inconsistent. Some take a table + column names, others take a column.

Desired solution

Normalize the interface. Also think about whether it makes sense to have the plotting stuff as methods of the Table or Column class (or both).

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@github-project-automation github-project-automation bot moved this to Backlog in Library Mar 22, 2023
@lars-reimann lars-reimann mentioned this issue Mar 22, 2023
Closed
@lars-reimann lars-reimann added cleanup 🧹 Refactorings and other tasks that improve the code and removed enhancement 💡 labels Mar 23, 2023
@lars-reimann lars-reimann moved this from Backlog to In Progress in Library Mar 26, 2023
@lars-reimann lars-reimann self-assigned this Mar 26, 2023
@lars-reimann lars-reimann linked a pull request Mar 26, 2023 that will close this issue
feat: move plotting methods into Column and Table classes #88
Merged
@lars-reimann lars-reimann mentioned this issue Mar 26, 2023
Merged
lars-reimann added a commit that referenced this issue Mar 26, 2023
@lars-reimann
feat: move plotting methods into Column and Table classes (#88)
5ec6189 
Closes #62.

### Summary of Changes

* Move plotting methods into `Column` and `Table` classes since they are
specific to these classes. We don't want to create a generic plotting
library.
* Remove the `plotting` module.

---------

Co-authored-by: lars-reimann <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in Library Mar 26, 2023
lars-reimann pushed a commit that referenced this issue Mar 26, 2023
@semantic-release-bot
chore(release): 0.5.0 [skip ci]
0c29a4a 
## [0.5.0](v0.4.0...v0.5.0) (2023-03-26)

### Features

* move plotting methods into `Column` and `Table` classes ([#88](#88)) ([5ec6189](5ec6189)), closes [#62](#62)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: move plotting methods into Column and Table classes Safe-DS/Library
1 participant
@lars-reimann