Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set site_url to fix broken 404 page on RTD #176

Merged
merged 5 commits into from
Jul 11, 2023
Merged

docs: set site_url to fix broken 404 page on RTD #176

merged 5 commits into from
Jul 11, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 5, 2023

Closes #443

Summary of Changes

The 404 page was previously not properly rendered on Read the Docs (RTD). This PR overrides the build commands of RTD. While this makes the 404 page work properly, it also removes the RTD flyout to select a version. For now, however, we deem the 404 page as more essential.

Once readthedocs/readthedocs.org#8529 is done, we can use the default build again to make everything work as expected.

@lars-reimann
Copy link
Member Author

lars-reimann commented Apr 5, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.1s
✅ YAML prettier 1 0 0 0.56s
✅ YAML v8r 1 0 2.13s
✅ YAML yamllint 1 0 0.23s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #176 (7909751) into main (44005f4) will not change coverage.
The diff coverage is n/a.

❗ Current head 7909751 differs from pull request most recent head 1b59d5b. Consider uploading reports for the commit 1b59d5b to get more accurate results

@@            Coverage Diff            @@
##              main      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2514      2514           
=========================================
  Hits          2514      2514           

@lars-reimann lars-reimann added the third party We need to wait for someone else label Apr 5, 2023
@lars-reimann lars-reimann marked this pull request as ready for review April 18, 2023 13:13
@lars-reimann lars-reimann requested a review from a team as a code owner April 18, 2023 13:13
@lars-reimann lars-reimann marked this pull request as ready for review July 11, 2023 08:12
@lars-reimann lars-reimann merged commit de04e2a into main Jul 11, 2023
@lars-reimann lars-reimann deleted the 404 branch July 11, 2023 08:13
@lars-reimann lars-reimann removed the third party We need to wait for someone else label Jul 11, 2023
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve layout of 404 error page
1 participant