Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more data processing steps to the classification tutorial #878

Conversation

LIEeOoNn
Copy link
Contributor

Closes #686

Summary of Changes

  1. Improved text
  2. removed columns name, id, ticket, parents_children, cabin completely
  3. OneHot encoded sex and port_embarked
  4. SimpleImpute age and fare
  5. reverse transformed OneHot encoding

@LIEeOoNn LIEeOoNn requested a review from a team as a code owner June 28, 2024 17:00
@LIEeOoNn LIEeOoNn linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jun 28, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.38s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (8f78163) to head (0a72f48).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   97.63%   97.67%   +0.03%     
==========================================
  Files         117      120       +3     
  Lines        6059     6234     +175     
==========================================
+ Hits         5916     6089     +173     
- Misses        143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading were still too long and technical. I've now added some suggestions that focus more on the task to solve than on API elements that must be used. You don't need to take the suggestions literally. If you have a different wording that is clearer or more concise, use it.

docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
docs/tutorials/classification.ipynb Outdated Show resolved Hide resolved
LIEeOoNn and others added 10 commits July 2, 2024 11:54
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final request:

Add some explanation to the sections

  • Marking the Target Column
  • Reverse-Transforming the Prediction
  • Testing the Accuracy of the Model

What do you do there and how?

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, excellent work.

@lars-reimann lars-reimann merged commit 3f5f4c4 into main Jul 2, 2024
10 checks passed
@lars-reimann lars-reimann deleted the 686-add-more-data-processing-steps-to-the-classification-tutorial branch July 2, 2024 15:40
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more data processing steps to the classification tutorial
2 participants