Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to safe-ds 0.17.1 + server refactor #37

Merged
merged 9 commits into from
Jan 14, 2024
Merged

feat: update to safe-ds 0.17.1 + server refactor #37

merged 9 commits into from
Jan 14, 2024

Conversation

WinPlay02
Copy link
Contributor

@WinPlay02 WinPlay02 commented Jan 12, 2024 •
edited
Loading

Summary of Changes

  • updated to safe-ds 0.17.1 + dependencies
  • temporarily disable python 3.12
  • changed image encoding to match new safe-ds version
  • removed jpeg test
  • refactored server stuff from main.py into a new class in server.py

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 0.58s
✅ PYTHON mypy 5 0 1.72s
✅ PYTHON ruff 5 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cae05c5) 100.00% compared to head (9e86acd) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          377       390   +13     
=========================================
+ Hits           377       390   +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WinPlay02 WinPlay02 marked this pull request as ready for review January 12, 2024 15:42
@WinPlay02 WinPlay02 requested review from a team and lars-reimann as code owners January 12, 2024 15:42
@WinPlay02 WinPlay02 marked this pull request as draft January 12, 2024 15:45
lars-reimann
lars-reimann previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lars-reimann
Copy link
Member

Is this still WIP or ready to merge?

@WinPlay02
Copy link
Contributor Author

There is a warning printed on every runner startup since this update, which I am trying to fix, that's why it is still WIP

@WinPlay02
refactor: put server infrastructure in a new class
9673268 
fix: warning related to (too) late monkey-patching

test: changed tests to new system
@WinPlay02
Merge branch 'library-update' of https://github.com/Safe-DS/Runner in…
b48e67d 
…to library-update
@WinPlay02
Copy link
Contributor Author

It seems like the update to the new library version causes the runner to startup slower (probably because of the larger amount of dependencies).

For the record, this was the warning:

src/safeds_runner/server/main.py:202: MonkeyPatchWarning: Monkey-patching ssl after ssl has already been imported may lead to errors, including RecursionError on Python 3.6. It may also silently lead to incorrect behaviour on Python 3.7. Please monkey-patch earlier. See https://github.com/gevent/gevent/issues/1016. 
Modules that had direct imports (NOT patched): ['urllib3.util (venv\\Lib\\site-packages\\urllib3\\util\\__init__.py)', 'urllib3.util.ssl_ (venv\\Lib\\site-packages\\urllib3\\util\\ssl_.py)'].
  patch_all()

I refactored the main.py a bit to fix this.

@WinPlay02 WinPlay02 changed the title feat: update to safe-ds 0.17.1 feat: update to safe-ds 0.17.1 + server refactor Jan 12, 2024
@WinPlay02 WinPlay02 marked this pull request as ready for review January 13, 2024 00:00
@lars-reimann lars-reimann merged commit 1bcad07 into main Jan 14, 2024
7 checks passed
@lars-reimann lars-reimann deleted the library-update branch January 14, 2024 19:29
lars-reimann pushed a commit that referenced this pull request Jan 26, 2024
@semantic-release-bot
chore(release): 0.5.0 [skip ci]
46630de 
## [0.5.0](v0.4.0...v0.5.0) (2024-01-26)

### Features

* added json serializer that encodes tables and images ([#29](#29)) ([054cca4](054cca4)), closes [#20](#20)
* Memoization ([#38](#38)) ([2a26b48](2a26b48))
* Replace flask with quart ([#43](#43)) ([5520b68](5520b68)), closes [#42](#42)
* support placeholder queries that only request a subset of data ([#39](#39)) ([dae57dc](dae57dc))
* update to safe-ds 0.17.1 + server refactor ([#37](#37)) ([1bcad07](1bcad07))

### Bug Fixes

* allow multiple connections to work with the runner ([#31](#31)) ([64685a3](64685a3))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WinPlay02 @lars-reimann @megalinter-bot