Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleaner public api #54

Merged
merged 4 commits into from
Feb 22, 2024
Merged

feat: cleaner public api #54

merged 4 commits into from
Feb 22, 2024

Conversation

lars-reimann
Copy link
Member

Closes #53

Summary of Changes

Define a small public interface consisting of

  • safeds_runner.file_mtime,
  • safeds_runner.memoized_call,
  • safeds_runner.save_placeholder.

These are used by the code generator of the DSL.

@lars-reimann lars-reimann requested a review from a team as a code owner February 21, 2024 19:11
@lars-reimann lars-reimann linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 12 0 0 0.97s
✅ PYTHON mypy 12 0 2.36s
✅ PYTHON ruff 12 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50f30a3) 100.00% compared to head (a61384e) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          499       500    +1     
=========================================
+ Hits           499       500    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann
Copy link
Member Author

@WinPlay02 Would you mind reviewing this?

@lars-reimann
Copy link
Member Author

lars-reimann commented Feb 21, 2024

It's also quite interesting that when I also add start_server to src/safeds_runner/__init__.py, the runtime of the tests increases from roughly 15s to 33s. This is apparently due to the imports of Image and Table in src/safeds_runner/server/_json_encoder.py, which then gets imported transitively.

Copy link
Contributor

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge

@lars-reimann lars-reimann changed the title refactor: cleaner public api feat: cleaner public api Feb 22, 2024
@lars-reimann lars-reimann merged commit 6d8dde7 into main Feb 22, 2024
9 checks passed
@lars-reimann lars-reimann deleted the 53-cleaner-public-api branch February 22, 2024 08:05
lars-reimann pushed a commit that referenced this pull request Feb 22, 2024
## [0.7.0](v0.6.0...v0.7.0) (2024-02-22)

### Features

* cleaner public api ([#54](#54)) ([6d8dde7](6d8dde7)), closes [#53](#53)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Feb 22, 2024
lars-reimann added a commit to Safe-DS/DSL that referenced this pull request Feb 22, 2024
### Summary of Changes

Adjust code generation to runner API changes (see
Safe-DS/Runner#54).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaner public API
2 participants