Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a top-level transformation hook #222

Closed
wants to merge 1 commit into from

Conversation

calvinwiebe
Copy link
Contributor

This adds in a simple hook to be able to get the transformed source without it being immediately written to disk. I did this as I wanted to use streamline with gulp, in a plugin here. I realize that most of the individual transform functions for the different runtimes are exposed. However, there is a lot of useful option parsing and also plain .coffee compiling provided in compile._js.

Details:

  1. Added a noWrite option.
  2. Factored out some common code to be used by both exports.compile and exports.transform
  3. I ran build.sh to generate a new ./lib/callbacks/compile.js. I hope that was appropriate.

Details:
To allow other build systems to programmatically use streamline. Particularly
gulp.
@bjouhier
Copy link
Member

@calvinwiebe Thanks. I'm on vacation. I'll review in 10 days because this is difficult with just a phone.

@bjouhier
Copy link
Member

bjouhier commented Aug 2, 2014

It looks good but you have removed the trailing spaces at the end of documentation lines (prefixed by /// - note: the space after the 3 slashes is important too). These comments are used to generate markdown files and trailing comments are meaningful in markdown.

Can you restore these lines and resubmit the PR. Thanks in advance.

@calvinwiebe
Copy link
Contributor Author

Will do! I'll close and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants