Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 244 #1979

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Release 244 #1979

merged 8 commits into from
Apr 24, 2023

Conversation

jcschultz
Copy link
Contributor

@jcschultz jcschultz commented Nov 21, 2022 •
edited by salesforce-org-metaci bot
Loading

Critical Changes

Changes

Issues Closed

New Metadata

Unpackaged Metadata

Deleted Metadata

Testing Notes

Unaggregated Pull Requests

  • Rename folder to prevent cci data error [PR1982]
  • Remove session ID usage [PR1983]

jcschultz and others added 4 commits November 21, 2022 09:20
@jcschultz
Update readme for next release
ca15c8d 
Signed-off-by: jcschultz <[email protected]>
@jcschultz
Rename folder to prevent cci data error
4b09368 
cci 3.71 introduced a feature that requires dataset directories that are named the same as an org definition, to include a sql file within them.

Signed-off-by: jcschultz <[email protected]>
@jcschultz
Remove session ID usage
7df1241 
The user’s session ID was being used to retrieve the namespace. This is no longer permitted and would fail security review. I’ve updated the code to allow the apex controller to pass the namespace to the UI instead.

I’ve also added a unit test.

Signed-off-by: jcschultz <[email protected]>
@jcschultz
Merge pull request #1982 from SalesforceFoundation/feature/244__johnF…
9e82e2e 
…ixDataloadNaming

Rename folder to prevent cci data error
@jcschultz jcschultz requested a review from a team as a code owner January 27, 2023 19:31
@jcschultz jcschultz requested a review from davidmreed January 27, 2023 19:31
@github-actions
Copy link

Hi 👋 @jcschultz! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@github-actions
Copy link

This PR has been labeled as ready for Release Engineering review by
@jcschultz. Reviews have been requested from: @davidmreed.

JimRigney-Lyra
JimRigney-Lyra approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@JimRigney-Lyra JimRigney-Lyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jcschultz jcschultz merged commit 6bb25a9 into main Apr 24, 2023
@jcschultz jcschultz deleted the feature/244 branch April 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmreed davidmreed davidmreed approved these changes

@JimRigney-Lyra JimRigney-Lyra JimRigney-Lyra approved these changes

Assignees
No one assigned
Labels
ready for RE review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcschultz @JimRigney-Lyra @davidmreed