Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

Update CODEOWNERS #1995

Closed
wants to merge 1 commit into from
Closed

Update CODEOWNERS #1995

wants to merge 1 commit into from

Conversation

kg345
Copy link
Contributor

@kg345 kg345 commented Jan 19, 2024

No description provided.

@@ -1,3 +1,3 @@
#ECCN: Open Source
#GUSINFO: Education Data Architecture (EDA), Education Data Architecture (EDA)

#GUSINFO: Rad-ish, Education Data Architecture & K-12 (MP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are spaces okay? The other codeowners PRs don't have spaces, so just want to make sure this is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good question - I was going off the confluence page where the examples show spaces in the names of product tag, at least.
https://confluence.internal.salesforce.com/display/corescm/Create+a+GUS-Aware+CODEOWNERS+File

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I just didn't know if "#GUSINFO: Rad-ish, Education Data Architecture & K-12 (MP)" vs "#GUSINFO:Rad-ish,Education Data Architecture & K-12 (MP)" made a difference, as I noticed all of the others are the latter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems they trim the line when the split the string (based on #GUSINFO) so I believe it should be ok with a space.

@kg345
Copy link
Contributor Author

kg345 commented Jan 22, 2024

Closing + opened a new PR with correct branch naming
#1996

@kg345 kg345 closed this Jan 22, 2024
@kg345 kg345 deleted the kgoncalves/scm-codeowners branch January 22, 2024 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants