added suspending for rendering #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to fix the lint errors. Run |
index.js
Outdated
| return task.shouldSuspendUpdateRenderer(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I feel like this logic belongs in listr and not the renderer.
There was a problem hiding this comment.
After writing the tests, i remove it to listr.
There was a problem hiding this comment.
This logic has been removed to listr with the commit 4685274.
|
This PR needs to add a test to prove it works correctly. |
index.js
Outdated
| @@ -44,8 +44,19 @@ const renderHelper = (tasks, options, level) => { | |||
| return output.join('\n'); | |||
| }; | |||
|
|
|||
| const shouldSuspendUpdateRenderer = tasks => { | |||
| for (const task of tasks) { | |||
| if (task.shouldSuspendUpdateRenderer()) { | |||
There was a problem hiding this comment.
Maybe use tasks.some() here to simplify the code?
itaisteinherz
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix issue np issue 79 these changes suspend the update-process, if the task set a suspend flag.