Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added tests for getRepositoryOrganization and getRepositoryName… #335

Closed
wants to merge 2 commits into from
Closed

test: added tests for getRepositoryOrganization and getRepositoryName… #335

wants to merge 2 commits into from

Conversation

elefrodi
Copy link

@elefrodi elefrodi commented Dec 1, 2023

…, changed tests for getPullRequestId, fix: changed WebhookUtil methods to return exceptions and not strings #301

Pull Request

Description

When an error occurs in some functions in LPVSWebhookUnit , an illegalArgumentException is now thrown instead of a string being returned. Unit tests for these functions also created/modified.

Fixes # (issue)
I resolved issue #301

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

I basically added tests so i don't think i can write something in this section.

Test Configuration:

  • Java: v11
  • LPVS Release: v1.2.0

Checklist:

  • [✓ ] My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • [ ✓] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [✓ ] My changes generate no new warnings
  • [✓ ] I have added tests that prove my fix is effective or that my feature works
  • [✓ ] New and existing unit tests pass locally with my changes

…, changed tests for getPullRequestId, fix: changed WebhookUtil methods to return exceptions and not strings #301
@o-kopysov
Copy link
Collaborator

o-kopysov commented Dec 1, 2023

@elefrodi
Copy link
Author

elefrodi commented Dec 1, 2023

Can you please explain to me how to do that?

@o-kopysov
Copy link
Collaborator

Can you please explain to me how to do that?

First of all, please apply the next code style fix:
code_style.patch

Next, you have unit tests failures. Please check and fix:
https://github.com/Samsung/LPVS/actions/runs/7060287285/job/19219604649?pr=335#step:6:2895

Regarding signing commits, please add "Signed-off-by: ...." as here 58644dc

@elefrodi elefrodi closed this Dec 1, 2023
@elefrodi elefrodi deleted the 301-LPVSWebhookUnit-ExceptionInsteadOfStringReturned branch December 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants