Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer last line without new line end #99

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Dec 1, 2024

This change looks large if whitespace changes are shown in diff....

This may not happen in act, but node doesn't ensure this will never happen.

e.g.
handeIO called with

line1
line2
line3
{.......................................................................................

now called again, notice no \n on the end of the buffer

.....................}
line5

this one ends with a newline again.

This change now buffers {....................................................................................... and joins it with .....................} to have a valid json line.

typeof j.msg === 'string is true as well if msg="", even if you cannot get act to log such thing by echo '' it's possible.

My Runner.Client transfers empty lines like that.

@SanjulaGanepola SanjulaGanepola merged commit b532ba4 into SanjulaGanepola:feature/step-and-job-level-output Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants