fixes in capsule upgrade playbook tests #10173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondrejk
added
TestFailure
pondrejk
force-pushed
the
caps-upgrade-job
branch
from
875979e to
f3f593d
Compare
Griffin-Sullivan
approved these changes
Oct 17, 2022
|
@pondrejk Could you add some background of the issue in description to know the issue for reviewers. |
pondrejk
force-pushed
the
caps-upgrade-job
branch
from
f3f593d to
67cc7c5
Compare
|
trigger: test-robottelo |
pondrejk
force-pushed
the
caps-upgrade-job
branch
from
67cc7c5 to
58f1ecf
Compare
|
trigger: test-robottelo |
pondrejk
force-pushed
the
caps-upgrade-job
branch
from
58f1ecf to
ab3daf9
Compare
|
trigger: test-robottelo |
|
@jyejare @Gauravtalreja1 mind revisiting? |
| f'{target_sat.url}/api/job_invocations/{job.id}/hosts/{sat.id}', | ||
| auth=(target_sat.username, target_sat.password), | ||
| f'{target_sat.url}/api/job_invocations/{job.id}/hosts/{host[0].id}', | ||
| auth=(settings.server.admin_username, settings.server.admin_password), |
There was a problem hiding this comment.
You can use get_credentials func from config to fetch this
vsedmik
approved these changes
Oct 21, 2022
pondrejk
added
CherryPick
pondrejk
force-pushed
the
caps-upgrade-job
branch
from
ab3daf9 to
ac1407a
Compare
pondrejk
force-pushed
the
caps-upgrade-job
branch
from
ac1407a to
e5886cd
Compare
ogajduse
approved these changes
Oct 24, 2022
| response = client.get( | ||
| f'{target_sat.url}/api/job_invocations/{job.id}/hosts/{sat.id}', | ||
| auth=(target_sat.username, target_sat.password), | ||
| f'{target_sat.url}/api/job_invocations/{job.id}/hosts/{host[0].id}', |
There was a problem hiding this comment.
using the following patch, you can delete L72.
Suggested change
| f'{target_sat.url}/api/job_invocations/{job.id}/hosts/{host[0].id}', | |
| f'{target_sat.url}/api/job_invocations/{job.id}/hosts/{target_sat.nailgun_host.id}', |
There was a problem hiding this comment.
hm, for some reason this didn't work for me when I was trying that out locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing some test failures in tests related to capsule upgrade playbook -- the capsule target version is no longer hardcoded, incorect hostname and credentials selection is also fixed