Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed maxTicketOpened #173

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Fixed maxTicketOpened #173

merged 3 commits into from
Jun 27, 2023

Conversation

Musiker15
Copy link
Contributor

Fixed maxTicketOpened if maxTicketOpened is set to higher number than 0

@zhiyan114 zhiyan114 mentioned this pull request Jun 26, 2023
Closed
@zhiyan114 zhiyan114 closed this Jun 26, 2023
@zhiyan114 zhiyan114 reopened this Jun 26, 2023
@zhiyan114 zhiyan114 requested review from zhiyan114 and Sayrix June 26, 2023 23:49
zhiyan114
zhiyan114 requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@zhiyan114 zhiyan114 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go head and simplify the !== to use > instead so that way, the query isn't called if the user decided to give it a negative value.

Also replace closereason with closedby and fix the lint issue.

zhiyan114
zhiyan114 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@zhiyan114 zhiyan114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, just figured out I'm able to edit files behalf of the user

@zhiyan114 zhiyan114 added this to the 3.1.0 milestone Jun 27, 2023
Sayrix
Sayrix approved these changes Jun 27, 2023
View reviewed changes
Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@Sayrix Sayrix merged commit 2172811 into Sayrix:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayrix Sayrix Sayrix approved these changes

@zhiyan114 zhiyan114 zhiyan114 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Musiker15 @zhiyan114 @Sayrix