Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code structure #176

Merged
merged 3 commits into from
Jun 29, 2023
Merged

refactor: code structure #176

merged 3 commits into from
Jun 29, 2023

Conversation

BattutDev
Copy link
Contributor

I made this PR from my dev branch where I've refactor the code structure of the project, using 'POO' concept, index files for exports from modules (directory)
In this branch the command & event handler has been removed for improving security and performance, handlers are useless with a little list of commands & event (also, the 'require' function is not a good practice in typescript, use 'import' if possible).

The 'src/utils' module has not been modified, but an import of functions from an index file (following the example of other modules) is to be planned.

I stay available if you have any questions or modifications to submit (note that this PR does not contain any new features or bug fixes, only a refactor of the project).

@Sayrix Sayrix requested a review from zhiyan114 June 29, 2023 12:09
Copy link
Collaborator

@zhiyan114 zhiyan114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I really like the new way of handling commands and DJS client.

@zhiyan114 zhiyan114 added this to the 3.1.0 milestone Jun 29, 2023
@Sayrix Sayrix merged commit 51db4b5 into Sayrix:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants