Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issues with remove command #290

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix: Issues with remove command #290

merged 3 commits into from
Oct 24, 2023

Conversation

zhiyan114
Copy link
Collaborator

Resolves #289

I've used the wrong object during the refactor phase, causing this issue.
Also discovered that removing user does not update the database (which I also missed).
So now, this command should work as intended.

@zhiyan114 zhiyan114 requested a review from Sayrix as a code owner October 24, 2023 21:35
@zhiyan114 zhiyan114 added this to the 5.3.0 milestone Oct 24, 2023
Copy link
Owner

@Sayrix Sayrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sayrix
Copy link
Owner

Sayrix commented Oct 24, 2023

Have you tried your code, by the way?

@zhiyan114
Copy link
Collaborator Author

ye, should work

@zhiyan114 zhiyan114 merged commit 2e2959f into main Oct 24, 2023
@zhiyan114 zhiyan114 deleted the 289fix branch October 24, 2023 21:42
@Sayrix
Copy link
Owner

Sayrix commented Oct 24, 2023

I renamed the milestone 3.3.0 instead of 5.3.0

@Sayrix
Copy link
Owner

Sayrix commented Oct 24, 2023

I'll push the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Remove Commands
2 participants