This repository has been archived by the owner on Jul 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -4,49 +4,58 @@ var utils = require("../utils"); | |||
var log = require("npmlog"); | |||
|
|||
module.exports = function(defaultFuncs, api, ctx) { | |||
return function getThreadInfo(threadID, callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you re-indent this back to 2 spaces
Looks good. Ready to merge when you fix the nitpicking. Thanks a lot! |
if (utils.getType(accept) !== 'Boolean') {
throw {
error: "Please pass a boolean as a second argument."
};
} Should that be != instead of !== as well? |
Oh no it should always be |
Can you check now? I also kept it as } else if (utils.getType(pending) != 'Boolean') {
throw {
error: "Please pass a Boolean as a third argument."
};
} else {
throw {
error: "getThreadList: need callback"
};
} Since you'll need to throw the last callback error if there is no boolean and no callback |
Sounds good. Thanks. |
how2945ard
pushed a commit
to how2945ard/facebook-chat-api
that referenced
this pull request
May 30, 2017
Add message request support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full credits to QuickUnit's commit
I changed the description a bit and changed the type checks as mentioned here .
I tested it and it seems to be working.
I did not modify the getThreadInfo file. The indents just changed.