Implementing addReaction function #427

gamelaster · 2017-03-26T12:46:37Z

ToDo:

Make it working
Add remove
Adding info to readme
Adding support for parsing reactions in listen or threadlist
Check which all emojis are supported

@mangotec or @ravkr
Could you test if it works? For me I getting error.

zoeyim · 2017-03-26T13:02:24Z

I am getting the same error

gamelaster · 2017-03-26T13:44:05Z

@mangotec I did changes, try it now, actually I got a error from utils.js, but it's not related to my code. Test it now. If it not will work, probably encodeURIComponent will be required

zoeyim · 2017-03-26T14:10:15Z

Yeah getting the same error as you

zoeyim · 2017-03-26T14:14:18Z

OK so I got it to work by changing doc_id to what was in the request, it is not the same as the thread id, but i am not sure what it is

Edit: it seems doc_id is always 1491398900900362 after trying multiple accounts talking to different people and in groups/pms

zoeyim · 2017-03-26T14:18:05Z

And it seems you cannot use emojis other than the default ones :(

gamelaster · 2017-03-26T14:52:41Z

@mangotec
By using your doc_id it's works (on my country it still not visisble, but in thread_info I got reactions)! Now wondering wthat doc_id could be, maybe static definition of app or something...

ravkr · 2017-03-26T15:54:29Z

I can't test it right now, but is there any way to remove reactions?

gamelaster · 2017-03-26T15:57:14Z

@ravkr I don't know, probably yes, but don't know how request looks

zoeyim · 2017-03-26T18:53:41Z

To remove a reaction you just need to replace "ADD_REACTION" with "REMOVE_REACTION"

Edit: Although the request has the emoji that you want to remove, you can actually just use any string and it will still successfully remove the reaction.

gamelaster · 2017-03-26T19:28:51Z

@mangotec Thank you! I will implement that!

Schmavery · 2017-03-26T21:34:32Z

Great to see this collaboration! Let me know when it's ready to merge :)

ravkr · 2017-03-28T17:41:23Z

@gamelaster you could use git rebase instead of merging from master, it just looks cleaner :D

gamelaster · 2017-03-28T18:38:57Z

@ravkr yeah,I like rebase more than merging, but I don't know why, it's merged instead of rebase/fast-forward :D

ravkr · 2017-03-28T19:31:46Z

you can try this next time 😄

git remote add upstream [email protected]:Schmavery/facebook-chat-api
git fetch upstream
git rebase upstream/master
git push -f origin master

gamelaster · 2017-03-29T09:17:11Z

Okay, I got the reactions update! Let's go finish it 😊

@ravkr ahh yeah, I used merge instead rebase (when I use merge, it will in some conditions rebase only the code)

gamelaster · 2017-03-29T11:52:43Z

It's ready!
@Schmavery please review the changes! 😊
BTW: There is a new delta "event", ClientPayload, it's encrypted JSON, already just contains reactions and something like PIN, #433

Schmavery · 2017-03-29T16:16:44Z

src/setMessageReaction.js

+var utils = require("../utils");
+var log = require("npmlog");
+
+var clientMutationId = 0;


This makes me nervous. Can you store this in the ctx object?

Schmavery · 2017-03-29T16:18:10Z

src/addReaction.js

@@ -0,0 +1,45 @@
+"use strict";


Did you intend to include this file?

Yeah, you are right! Fixed

…ebook-chat-api into feature-reactions

gamelaster · 2017-03-29T16:24:41Z

Oyy, I again merged instead of rebase! 😆 All reviews has been solved!

Schmavery · 2017-03-29T16:28:40Z

src/setMessageReaction.js

+
+    var variables = {
+      data: {
+        client_mutation_id: ctx.clientMutationId++,


I think this will give NaN if ctx.clientMutationId is not initialized to a number.
You can fix that here: https://github.com/Schmavery/facebook-chat-api/blob/master/index.js#L58

https://github.com/Schmavery/facebook-chat-api/pull/427/files#diff-168726dbe96b3ce427e7fedce31bb0bcR65
Is it already 😊

Oh ok, sorry I must have missed that.

Schmavery · 2017-03-29T16:47:10Z

utils.js

@@ -375,7 +375,8 @@ function formatDeltaMessage(m){
    messageID: md.messageId,
    attachments: (m.delta.attachments || []).map(v => _formatAttachment(v)),
    timestamp: md.timestamp,
-    isGroup: !!md.threadKey.threadFbId
+    isGroup: !!md.threadKey.threadFbId,
+    reactions: originalMessage.reactions ? originalMessage.reactions : []


Am I going crazy or is originalMessage not defined here? Can you make sure to test this change? deltaMessage can have slightly different behaviour than the other one (unless you're not getting delta messages?).

Well, when I thinking about this, the reactions in deltaMessage is not required because all reactions sync going through ClientPayload

Sorry, I don't understand. Can you explain more? Does delta message not have info about reactions?
Mhh... because it sends the delta message right away, so no one could have reacted to it yet?

As far as I know, Delta message doesn't have info about reactions. But, the information about reaction is still in /pull/ request, but marked as ClientPayload. So first you get DeltaMessage and then ClientPayload contains Message Reaction

Ok, I think that can work.

Schmavery · 2017-03-29T20:15:18Z

src/listen.js

+                if (clientPayload && clientPayload.deltas) {
+                  for (var i in clientPayload.deltas) {
+                    var delta = clientPayload.deltas[i];
+                    if (delta.deltaMessageReaction) {


Sorry, just one more thing. Can you explicitly create and return a new object? This will help if facebook changes the format of the object they send us, I believe.
Why do you delete delta.threadKey and delta.action?

I think threadKey and action is useless.
And I did that new object.

ravkr · 2017-03-29T22:28:02Z

DOCS.md

+__Arguments__
+
+* `reaction`: A string contains `emoji`, `emoji shortcut`, `emoji in unicode` or left `empty string` for delete reaction (look down for list of supported emojis)
+* `messageID`: A string or number representing a thread. It happens to be someone's userId in the case of a one to one conversation.


A string or number representing a thread
so... it is threadID or messageID?

Oops! It's a messageID !

ravkr · 2017-03-29T22:44:39Z

src/listen.js

+                    var delta = clientPayload.deltas[i];
+                    if (delta.deltaMessageReaction) {
+                      delta.deltaMessageReaction.type = "message_reaction";
+                      delta.threadId = delta.threadKey.threadFbId;


i used this code:

var fs = require("fs"); var login = require("facebook-chat-api"); login({appState: JSON.parse(fs.readFileSync('appstate.json', 'utf8'))}, (err, api) => { if(err) return console.error(err); api.setOptions({listenEvents: true, logLevel: "silly"}); var stopListening = api.listen((err, event) => { if(err) return console.error(err); if (event.type === "message") { console.log(JSON.stringify(event)); //api.addReaction("👍", event.threadID, event.messageID); api.setMessageReaction("\uD83D\uDE0D", event.messageID, (err) => { console.error(err); }) } }); });

and I got this error:

verb parseAndCheckLogin for (;;); {"t":"msg","seq":12,"u":100015305950325,"ms":[{"ofd_ts":1490827124159,"delta":{"payload":[123,34,100,101,108,116,97,115,34,58,91,123,34,100,101,108,116,97,77,101,115,115,97,103,101,82,101,97,99,116,105,111,110,34,58,123,34,116,104,114,101,97,100,75,101,121,34,58,123,34,111,116,104,101,114,85,115,101,114,70,98,73,100,34,58,49,48,48,48,48,49,51,51,49,51,56,53,53,55,48,125,44,34,109,101,115,115,97,103,101,73,100,34,58,34,109,105,100,46,36,99,65,65,65,65,66,102,56,100,69,74,100,104,84,88,51,100,89,70,98,72,68,105,87,101,117,88,101,80,34,44,34,97,99,116,105,111,110,34,58,48,44,34,117,115,101,114,73,100,34,58,49,48,48,48,49,53,51,48,53,57,53,48,51,50,53,44,34,114,101,97,99,116,105,111,110,34,58,34,92,117,48,48,102,48,92,117,48,48,57,102,92,117,48,48,57,56,92,117,48,48,56,100,34,44,34,115,101,110,100,101,114,73,100,34,58,49,48,48,48,48,49,51,51,49,51,56,53,53,55,48,44,34,111,102,102,108,105,110,101,84,104,114,101,97,100,105,110,103,73,100,34,58,34,54,50,53,50,57,56,50,49,54,50,51,54,54,55,53,54,55,53,49,34,125,125,93,125],"class":"ClientPayload"},"type":"delta","iseq":283814,"queue":100015305950325}]} info listen Got answer in 282 ERR! listen TypeError: Cannot read property 'threadFbId' of undefined ERR! listen at parsePackets (/var/www/node/react/node_modules/facebook-chat-api/src/listen.js:163:55) ERR! listen at Array.forEach (native) ERR! listen at /var/www/node/react/node_modules/facebook-chat-api/src/listen.js:107:12 ERR! listen at tryCatcher (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/util.js:26:23) ERR! listen at Promise._settlePromiseFromHandler (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/promise.js:510:31) ERR! listen at Promise._settlePromiseAt (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/promise.js:584:18) ERR! listen at Promise._settlePromises (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/promise.js:700:14) ERR! listen at Async._drainQueue (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/async.js:123:16) ERR! listen at Async._drainQueues (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/async.js:133:10) ERR! listen at Immediate.Async.drainQueues [as _onImmediate] (/var/www/node/react/node_modules/facebook-chat-api/node_modules/bluebird/js/main/async.js:15:14) ERR! listen at processImmediate [as _immediateCallback] (timers.js:383:17) ERR! listen [TypeError: Cannot read property 'threadFbId' of undefined] [TypeError: Cannot read property 'threadFbId' of undefined]

Strange, after decoding your clientPayload, I got this response:

It's different than mine.

Oh, In my old parsed files, It's contains threadFbId, but today new parsed I have otherUserFbId too ! Maybe hotfix or something from Facebook side?

Not sure I follow 100% but if it seems like a value is sometimes in one place and sometimes in another, please support both 😄
Sometimes people have different versions and it would be great to have the api work for everyone.

ravkr · 2017-03-29T22:54:07Z

src/setMessageReaction.js

+      case ":thumbsdown:":
+        reaction = "\uD83D\uDC4E";
+      default:
+        return callback({error: "reaction is not valid emoji"});


you forgot to add breaks to cases, now it always calls callback with error.
and maybe "Reaction is not a valid emoji." instead of "reaction is not valid emoji"?

Great catch, thanks @ravkr

Oh, thanks @ravkr !

you've added one break, but it needs a break after every reaction = ...;

Oh yea, sorry, when I arrive home I will fix that 🤣

gamelaster · 2017-03-30T17:42:54Z

Should be okay right now I hope! 😆

Schmavery · 2017-03-30T17:48:33Z

Work for you @ravkr?

ivkos · 2017-03-30T18:07:07Z

DOCS.md

+* 😢 - Unicode: `\uD83D\uDE22`, Shortcut: `:cry:`
+* 😠 - Unicode: `\uD83D\uDE20`, Shortcut: `:angry:`
+* 👍 - Unicode: `\uD83D\uDC4D`, Shortcut: `:thumbsup:`
+* 👎 - Unicode: `\uD83D\uDC4E`, Shortcut: `:thumbsdown:`


In my opinion, it would be better if reaction names shortcuts were unified with the names of the reactions for Facebook posts, i.e.:

:love:

:haha:

:wow:

:sad:

:angery:

:like:

:dislike:

@ivkos hmm, probably you are right, I just used an "unified" emoji shortcuts. Let's left decide to @Schmavery

I don't mind the unified ones, we could potentially support both. @ivkos do you have a source for these "canonical" facebook reaction names?

@Schmavery They are not really canonical. It's what they're called in the Facebook UI and how most users know them. Reactions in Messenger don't have visible names in the UI, but most of my friends call them basically with the names of the corresponding reactions in Facebook.

but facebook's :love: is heart, not eyes with hearts... :/

Okey, I added support for Facebook shortcuts 😊

ravkr · 2017-03-30T18:16:34Z

everything seems to work fine 😄

my test code:

var fs = require("fs");
var login = require("facebook-chat-api");

var x = 0;
var reactions = [
    "\uD83D\uDE0D",
    "\uD83D\uDE06",
    "\uD83D\uDE2E",
    "\uD83D\uDE22",
    "\uD83D\uDE20",
    "\uD83D\uDC4D",
    "\uD83D\uDC4E",
    ":heart_eyes:",
    ":laughing:",
    ":open_mouth:",
    ":cry:",
    ":angry:",
    ":thumbsup:",
    ":thumbsdown:"
]

login({appState: JSON.parse(fs.readFileSync('appstate.json', 'utf8'))}, (err, api) => {
    if(err) return console.error(err);

    api.setOptions({listenEvents: true, logLevel: "silly"});

    var stopListening = api.listen((err, event) => {
        if(err) return console.error(err);

        if (event.type === "message" && event.body.toLowerCase().indexOf("rav") === 0) {
            console.log(JSON.stringify(event));
            api.setMessageReaction(reactions[x], event.messageID, (err) => {
                console.error(err);
            })
            console.log(`reaction test #${x}`);
            x = (x+1)%reactions.length;
        }
    });
});

ravkr · 2017-03-30T18:23:20Z

src/setMessageReaction.js

        reaction = "\uD83D\uDE22";
        break;
      case ":angry:":
+      case ":angery:":


it was probably typo in suggestion... :/ on facebook it is still angry

I added it from list which provided me @ivkos, but as I remember, it is angery, but not sure!

but he must have made mistake :(

Yeah, you are right, it's angry (checked myself too)! Fixed

Schmavery · 2017-03-30T19:42:14Z

Thanks a lot for this @gamelaster! I appreciate you taking all my little bits of feedback into account and finishing this so quickly!
Thanks also to @ravkr for the great test work :)
I love our little facebook-chat-api community! 😄

* Implementing setMessageReaction function * Adding documentation for setMessageReaction * Adding Facebook emoji shortcuts to setMessageReaction

Implementing addReaction function

c6957bf

Patching tipos

a34c12b

Adding static doc_id

325f16f

Merge remote-tracking branch 'upstream/master' into feature-reactions

6161ed8

gamelaster and others added 10 commits March 29, 2017 12:30

Renaming addReaction to setMessageReaction

99655f7

Adding reactions variable into message template

23c26e6

Relative incrementing client_mutation_id

1ec7ad1

Adding REMOVE_REACTION support

915993f

Parsing reactions via Client Payload

4a8842a

Only supported reaction emojis and conversion from text

2211491

Adding threadId into message reaction template

bdb9284

Removing unused argument on setMessageReaction

9c313ab

Adding documentation for setMessageReaction

8d459e5

Adding setMessageReaction on README.MD

7dd583d

Schmavery reviewed Mar 29, 2017

View reviewed changes

gamelaster added 2 commits March 29, 2017 18:21

Removing old addReaction file and move clientMutationId to ctx

d476290

Merge branch 'feature-reactions' of https://github.com/GAMELASTER/fac…

6248686

…ebook-chat-api into feature-reactions

Schmavery reviewed Mar 29, 2017

View reviewed changes

Adding reactions into delta and into documentation

b74b5e3

Schmavery reviewed Mar 29, 2017

View reviewed changes

Reverting reaction implement into delta messages

7f458e1

Schmavery reviewed Mar 29, 2017

View reviewed changes

ravkr suggested changes Mar 29, 2017

View reviewed changes

ravkr reviewed Mar 29, 2017

View reviewed changes

gamelaster added 4 commits March 30, 2017 11:36

Adding forgotten break

d8365fc

New reaction object + threadId fix

158e2ed

Fixed description of messageId

a2b54ee

Adding other forgotten breaks

c933951

ivkos reviewed Mar 30, 2017

View reviewed changes

gamelaster added 2 commits March 30, 2017 20:10

Adding back compatilibity for threadKey.threadFbId

c55efec

Adding Facebook emoji shortcuts

4b2dc82

ravkr reviewed Mar 30, 2017

View reviewed changes

gamelaster force-pushed the feature-reactions branch from fa0ee69 to 4b2dc82 Compare March 30, 2017 18:52

Removing :angery: shortcut

a2eb5a5

Schmavery merged commit 5676a33 into Schmavery:master Mar 30, 2017

bsansouci pushed a commit that referenced this pull request Apr 1, 2017

Implementing setReaction function (#427)

9e919eb

* Implementing setMessageReaction function * Adding documentation for setMessageReaction * Adding Facebook emoji shortcuts to setMessageReaction

Implementing addReaction function #427

Implementing addReaction function #427

Conversation

gamelaster commented Mar 26, 2017 • edited Loading

zoeyim commented Mar 26, 2017

gamelaster commented Mar 26, 2017 • edited Loading

zoeyim commented Mar 26, 2017

zoeyim commented Mar 26, 2017 • edited Loading

zoeyim commented Mar 26, 2017

gamelaster commented Mar 26, 2017 • edited Loading

ravkr commented Mar 26, 2017

gamelaster commented Mar 26, 2017

zoeyim commented Mar 26, 2017 • edited Loading

gamelaster commented Mar 26, 2017

Schmavery commented Mar 26, 2017

ravkr commented Mar 28, 2017

gamelaster commented Mar 28, 2017

ravkr commented Mar 28, 2017

gamelaster commented Mar 29, 2017

gamelaster commented Mar 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gamelaster commented Mar 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gamelaster Mar 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gamelaster commented Mar 30, 2017

Schmavery commented Mar 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivkos Mar 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravkr commented Mar 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Schmavery commented Mar 30, 2017 • edited Loading

gamelaster commented Mar 26, 2017 •

edited

Loading

gamelaster commented Mar 26, 2017 •

edited

Loading

zoeyim commented Mar 26, 2017 •

edited

Loading

gamelaster commented Mar 26, 2017 •

edited

Loading

zoeyim commented Mar 26, 2017 •

edited

Loading

gamelaster commented Mar 29, 2017 •

edited

Loading

gamelaster Mar 29, 2017 •

edited

Loading

ivkos Mar 30, 2017 •

edited

Loading

Schmavery commented Mar 30, 2017 •

edited

Loading