Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some unneded strong dependencies #155

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

KristofferC
Copy link
Contributor

@KristofferC KristofferC commented Mar 21, 2023

Drive-by commit.

These dependencies are either loaded in 1.9 using the extension system or on 1.8 using Requires. In no case are they needed to be in [deps].

This avoids installing these dependencies (and adding them to sysimages) in Julia 1.8.

KristofferC and others added 2 commits March 21, 2023 13:37
These are either loaded in 1.9 using the extension system or on 1.8 using Requires. In no case are they needed to be in [deps]
@ChrisRackauckas
Copy link
Member

Thanks for catching that. @ven-k take note. Requires.jl needed a compat anyways so good you caught it now.

@ChrisRackauckas ChrisRackauckas merged commit 50d8f2c into SciML:master Mar 21, 2023
@ven-k
Copy link
Member

ven-k commented Mar 21, 2023

Noted

@KristofferC KristofferC deleted the kc/deps branch March 21, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants