Add extrapolation keyword #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/derivatives.jl
Outdated
| @@ -1,4 +1,7 @@ | |||
| derivative(A, t) = derivative(A, t, firstindex(A.t) - 1)[1] | |||
| function derivative(A, t) | |||
| ((t < A.t[1] || t > A.t[end]) && !A.extrapolate) && error("Cannot extrapolate!") | |||
There was a problem hiding this comment.
we should make this an error type and throw it.
There was a problem hiding this comment.
Addressed in d45c36f
sathvikbhagavan
force-pushed
the
sb/add_extrapolate_keyword
branch
from
ed776c8 to
1802631
Compare
ChrisRackauckas
approved these changes
Oct 17, 2023
|
It might be nice to turn off extrapolation by default. Worth chatting about. |
Yeah, it might be better as the expected behaviour of any interpolation should be within the range of time points provided. |
|
yes |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.