Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSplineInterpolation: Add support for higher order arrays #349

Merged
merged 10 commits into from
Oct 21, 2024
Merged

BSplineInterpolation: Add support for higher order arrays #349

merged 10 commits into from
Oct 21, 2024

Conversation

ashutosh-b-b
Copy link
Contributor

@ashutosh-b-b ashutosh-b-b commented Oct 19, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ashutosh-b-b ashutosh-b-b mentioned this pull request Oct 19, 2024
Draft
11 tasks
sathvikbhagavan
sathvikbhagavan suggested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@sathvikbhagavan sathvikbhagavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interpolation looks good. Can you add the derivative methods as well?

@ashutosh-b-b
Copy link
Contributor Author

Interpolation looks good. Can you add the derivative methods as well?

I have added derivative methods and relevant tests.

sathvikbhagavan
sathvikbhagavan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@sathvikbhagavan sathvikbhagavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also add BSpline support for vector of vectors as well next? That can be a follow up PR.

@ChrisRackauckas ChrisRackauckas merged commit 76c545b into SciML:master Oct 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathvikbhagavan sathvikbhagavan sathvikbhagavan approved these changes

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashutosh-b-b @ChrisRackauckas @sathvikbhagavan