Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Nonlinear Laplacian handling #291

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Jul 20, 2023

Extend the nonlinear handling to deal with additional derivs inside the first

Further extension may enable decent mixed derivatives handling, tests needed.

Testing against half ice dome at present

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #291 (5eba37b) into master (c360747) will decrease coverage by 30.02%.
The diff coverage is 86.48%.

@@             Coverage Diff             @@
##           master     #291       +/-   ##
===========================================
- Coverage   81.56%   51.55%   -30.02%     
===========================================
  Files          36       35        -1     
  Lines        1660     1676       +16     
===========================================
- Hits         1354      864      -490     
- Misses        306      812      +506     
Files Changed Coverage Δ
src/system_parsing/pde_system_transformation.jl 36.11% <ø> (-21.12%) ⬇️
...schemes/nonlinear_laplacian/nonlinear_laplacian.jl 86.53% <82.14%> (-13.47%) ⬇️
...schemes/spherical_laplacian/spherical_laplacian.jl 85.18% <100.00%> (-7.13%) ⬇️
src/system_parsing/interior_map.jl 85.35% <100.00%> (-6.32%) ⬇️

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax xtalax merged commit 90aa78e into SciML:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant