Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an FAQ page #451

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Add an FAQ page #451

merged 1 commit into from
Jan 8, 2023

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #451 (a60388e) into master (0283386) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   26.90%   26.90%           
=======================================
  Files          34       34           
  Lines        1375     1375           
=======================================
  Hits          370      370           
  Misses       1005     1005           
Impacted Files Coverage Δ
src/function/finitediff.jl 93.02% <ø> (ø)
src/function/forwarddiff.jl 95.23% <ø> (ø)
src/function/reversediff.jl 85.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit a095e27 into master Jan 8, 2023
@ChrisRackauckas ChrisRackauckas deleted the faq branch January 8, 2023 19:45
@Vaibhavdixit02
Copy link
Member

This is great, let's not do a release for it yet though. The structural simplify doesn't work for OptmizationSystem yet in my experience. I will finish up SciML/ModelingToolkit.jl#1983 and #432 soon and then try to write out the tutorial with it working.

@ChrisRackauckas
Copy link
Member Author

The structural simplify doesn't work for OptmizationSystem yet in my experience

Didn't Yingbo fix that up mid December? There's tests on it now.

@Vaibhavdixit02
Copy link
Member

You are right, the PR had issues because I had misunderstood the structural simplification for optimization system. I'll create a release and get this out 👍

@ValentinKaisermayer
Copy link
Contributor

What can structual_simplify offer for an optimization problem other than alias elimination?

@ChrisRackauckas
Copy link
Member Author

Tearing. What I wrote out was tearing, which requires splitting and solving subsystems. Alias elimination cannot perform solves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants