Added method dependent_scripts
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 646
💛 - Coveralls |
lib/daru/view.rb
Outdated
| # @example | ||
| # To load the dependent JS file for Nyaplot and GoogleCharts libraries | ||
| # Daru::View.load_libs_in_iruby(['nyaplot','googlecharts']) | ||
| def load_libs_in_iruby(libraries=[]) |
There was a problem hiding this comment.
I think we can use the dependent_script method to load js in iruby as well as web frameworks.
We can check for IRuby and accordingly load js .
|
Examples for loading multiple adapters. |
Prakriti-nith
changed the title
load_libs_in_irubyldependent_scripts
Prakriti-nith
changed the title
ldependent_scriptsdependent_scripts
lib/daru/view.rb
Outdated
| # | ||
| # Daru::View.load_lib_in_iruby('nyaplot') | ||
| # Daru::View.dependent_script(:nyaplot) |
There was a problem hiding this comment.
Write both examples passing string as well as symbol. In method documentation you should write the input parameter datatypes along with return value details.
spec/view_spec.rb
Outdated
| context "#dependent_scripts" do | ||
| let(:script) { | ||
| Daru::View.dependent_scripts( | ||
| [:googlecharts, :nyaplot, :highcharts, :datatables] |
lib/daru/view.rb
Outdated
| private | ||
|
|
||
| # @param libraries [Array] Adapters whose JS files will be loaded | ||
| # @return [void] load the dependent JS files for the adapter in IRuby notebook |
Shekharrajak
approved these changes
Jul 28, 2018
lib/daru/view.rb
Outdated
| # | ||
| # @param lib [String, Symbol] library whose dependencies are to be loaded | ||
| # @return [void, String] dependent script for the library | ||
| # @example |
There was a problem hiding this comment.
Need to verify, how it looks in yard document.
|
@Prakriti-nith , Anything else you want to add in this PR ? |
|
@Shekharrajak I think it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method can be used to load multiple adapter at once in iruby notebook.
Examples