Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google chart were not loading because URL deprecated #158

Merged
merged 13 commits into from
Oct 2, 2020

Conversation

Shekharrajak
Copy link
Member

References to other Issues or PRs

Fixes #157

Brief description of what is fixed or changed

google_visualr.js seems deprecated and URL is no more available like:

google.com/uds

Removed the file and only loader.js file is needed.

Testcase / documentation

existing cases should work - verified demo_iruby examples

@Shekharrajak Shekharrajak changed the title 157 google chart Google chart were not loading because URL deprecated Oct 2, 2020
@Shekharrajak
Copy link
Member Author

Also fixed similar issue : rubocop/rubocop#7117

@Shekharrajak Shekharrajak merged commit b4ac5fd into master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Charts not Loading
1 participant