Improve tests coverage for plot.rb #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,23 +91,44 @@ | |||
| context 'Googlecharts library' do | |||
| before { Daru::View.plotting_library = :googlecharts } | |||
| let(:lib) { Daru::View.plotting_library } | |||
| let(:options) {{width: 800, height: 720}} | |||
There was a problem hiding this comment.
{{width: 800, height: 720}} -> {width: 800, height: 720}
There was a problem hiding this comment.
I tried doing it, but am getting the following Syntax error: syntax error, unexpected ':', expecting '}' let(:options) {width: 800, height: 720}
and as mentioned here: https://stackoverflow.com/questions/21336438/using-a-hash-inside-a-let, double brackets should be used.
There was a problem hiding this comment.
Ah! it's correct, since we are using let.
|
Please refer the issue in your PR. It will be easy to find all the related changes for particular issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for the issue #67
Added more tests in plot_spec.rb