-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Charteditor #96
Merged
Shekharrajak
merged 18 commits into
SciRuby:master
from
Prakriti-nith:charteditor_wrapper
Aug 2, 2018
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
abacb2d
Added Chartwrapper
Prakriti-nith 3dd8fff
Added documentation
Prakriti-nith 7680fd2
Load packages explicitly in chartwrapper
Prakriti-nith 6a70844
Added Charteditor
Prakriti-nith d531fe2
Added example
Prakriti-nith a30450f
Update tests and documentation
Prakriti-nith 5defa69
Line length
Prakriti-nith 3d1e97a
Use already present template
Prakriti-nith be2939d
Changed wrapper_id to wrapper
Prakriti-nith 81ac864
Resolve conflicts
Prakriti-nith 85cc0b9
Move common methods to display
Prakriti-nith f99a319
Remove redundancy
Prakriti-nith 68d3125
Merge branch 'master' into charteditor_wrapper
Prakriti-nith eccd285
Fix rubocop offences
Prakriti-nith cf66066
Merge branch 'master' into charteditor_wrapper
Prakriti-nith 3829d87
Added module DisplayJavaScript, rechecked examples
Prakriti-nith 6f94d7b
Refactored display.rb into separate files
Prakriti-nith 5de4ed7
Remove extra variables from specs
Prakriti-nith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChartEditor is going through
data_table_iruby.rb
:O . But why ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChartEditor works for both google charts and tables, and code to generate the table is written in
data_table_iruby.rb
.charteditor
package is loaded in Google Datatables whenchart_class
is set to Charteditor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any example or documentation written, which describes this usecase ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have written the rails examples in demo_daru-view and also in the method documentation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write examples in web apps and iruby as well, if haven't.