fix: Move ipcRenderer calls into useEffect

Prevents ipcRenderer callbacks happening on uninitialised components
ScottLogic · Sep 7, 2021 · b8de6ea · b8de6ea
1 parent 16c8d88
commit b8de6ea
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/components/ResultsWindow.tsx b/src/components/ResultsWindow.tsx
@@ -56,10 +56,6 @@ const ResultsWindow: FunctionComponent<ResultsWindowProps> = ({
 
   const theme = useTheme();
 
-  ipcRenderer.invoke("is-dark-mode").then((isDarkMode) => {
-    setIsDarkMode(isDarkMode);
-  });
-
   const currentResults = results?.data;
   const error = results?.error;
   const currentScript = results?.script;
@@ -109,6 +105,10 @@ const ResultsWindow: FunctionComponent<ResultsWindowProps> = ({
       Exporter.cleanup(file);
     });
 
+    ipcRenderer.invoke("is-dark-mode").then((isDarkMode) => {
+      setIsDarkMode(isDarkMode);
+    });
+
     return () => {
       ipcRenderer.removeAllListeners("download-complete");
     };