Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beat msg for Enter represents strings with double quotes #40

Closed
MarcelWilson opened this issue Jan 10, 2024 · 3 comments
Closed

beat msg for Enter represents strings with double quotes #40

MarcelWilson opened this issue Jan 10, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@MarcelWilson
Copy link
Contributor

I noticed strings passed into Enter log using double quotes.

Marcel enters "foo" into the target.

All of the other string representations use single quotes.

@perrygoy
Copy link
Member

This is a complicated one for me.

I do want consistency, but English wouldn't use single-quotes like that. Honestly i would prefer it if we could find a way to make the other string representations use double-quotes.

@bandophahita
Copy link
Contributor

I hear you. I love double quotes. I'm not sure that's possible without some seriously low level hacking.

Hamcrest uses repr(value) for strings, which python always uses single quotes. In fact I essentially pulled represent_prop from their code.

@perrygoy
Copy link
Member

Haha and directly after i made that comment, i went to read a book where the author exclusively used single quotes to 'quote people.' I shouldn't have been so absolute in my comment.

English is, as ever, English. Let's be consistent.

bandophahita added a commit to bandophahita/screenpy_selenium that referenced this issue Feb 8, 2024
bandophahita added a commit to bandophahita/screenpy_selenium that referenced this issue Feb 21, 2024
bandophahita added a commit to bandophahita/screenpy_selenium that referenced this issue Feb 22, 2024
bandophahita added a commit to bandophahita/screenpy_selenium that referenced this issue Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants