feat: plain span element for last item #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrum
approved these changes
Dec 8, 2022
|
@OlofFredriksson The broken tests are not related to your changes. Can you fix them? |
|
I'm not sure how the clinton package works.. locally i disabled the pkg-schema validation since i dont understand the reason to have them at all. Is it okay to disable them, or do you know how to fix them? |
|
You can turn off the rules on which validation does not pass. Thank you. |
OlofFredriksson
force-pushed
the
router-link-last-element
branch
from
457eb3c
to
e495888
Compare
|
need rebase this branch |
OlofFredriksson
force-pushed
the
router-link-last-element
branch
from
e495888
to
c3d2636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to make the last (current node) as clickable. Also for accessibility reasons its bad practice to use span-element for a clickable element.
This change is semi breaking, since the router link classes never will be added to the element.