Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scttpr/fix/issue10638 check 0.0.0.0 #1

Closed

Conversation

vlmlee
Copy link

@vlmlee vlmlee commented Nov 3, 2022

Description

I updated the fix with the suggestion from sapphi-red to check the 0.0.0.0 pseudo-address first. I used a try/catch block to simplify the code and abort any further code if an error is thrown. The error event listener is not named but I think this is okay since the server will not get anywhere after the Promise rejects.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sorry, something went wrong.

@vlmlee vlmlee changed the base branch from main to fix/issue10638 November 3, 2022 02:54
@vlmlee vlmlee closed this Nov 3, 2022
@vlmlee vlmlee deleted the Scttpr/fix/issue10638-check-0.0.0.0 branch November 3, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant