Scttpr/fix/issue10638 check 0.0.0.0 #1
Closed
+17
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the fix with the suggestion from sapphi-red to check the 0.0.0.0 pseudo-address first. I used a try/catch block to simplify the code and abort any further code if an error is thrown. The
error
event listener is not named but I think this is okay since the server will not get anywhere after the Promise rejects.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).