Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-23588: Changes to accomodate miniprovisioning in kubernates envir… #472

Merged
merged 2 commits into from
Aug 25, 2021
Merged

EOS-23588: Changes to accomodate miniprovisioning in kubernates envir… #472

merged 2 commits into from
Aug 25, 2021

Conversation

rahul-tripathi-git
Copy link
Contributor

@rahul-tripathi-git rahul-tripathi-git commented Aug 23, 2021 •
edited
Loading

Problem Statement

  • The mini provisioning needs modification to be performed in kubernetes environmenyt

Design

  • The containerized deployment of cortx-py-utils needs to be accomodated in such a way that config phase will conatin most of the configuration changes. Also there should be no check for any service or any package presence

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@rahul-tripathi-git rahul-tripathi-git changed the base branch from main to kubernetes August 23, 2021 19:33
sachinpunadikar
sachinpunadikar suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on the comment

sachinpunadikar
sachinpunadikar approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit 201999f into Seagate:kubernetes Aug 25, 2021
vastradparayya pushed a commit to vastradparayya/cortx-utils that referenced this pull request Sep 1, 2021
@vaibhavparatwar @shailesh-vaidya
EOS-21367 Add puppet-agent for facter cli used in cortx-hare component (
1988297 
Seagate#472)

* EOS-21367 PR

Signed-off-by: Vaibhav Paratwar <[email protected]>

* changes as per discussed

Signed-off-by: Vaibhav Paratwar <[email protected]>

* corrected alphabetical order

Signed-off-by: Vaibhav Paratwar <[email protected]>

Co-authored-by: Shailesh Vaidya <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@s-arya s-arya Awaiting requested review from s-arya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-tripathi-git @sachinpunadikar @rohit-k-dwivedi