Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-22309: Utils server IP- removed localhost #487

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

suryakumar1024
Copy link
Contributor

@suryakumar1024 suryakumar1024 commented Aug 27, 2021

Signed-off-by: suryakumar.kumaravelan [email protected]

Problem Statement

  • Need to remove host parameter from the run_app.

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

shriya-deshmukh and others added 2 commits August 26, 2021 13:50
Signed-off-by: Shriya Deshmukh <[email protected]>

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
@rahul-tripathi-git rahul-tripathi-git changed the base branch from main to kubernetes August 27, 2021 13:00
@rahul-tripathi-git rahul-tripathi-git merged commit 81c6bab into Seagate:kubernetes Aug 27, 2021
vastradparayya pushed a commit to vastradparayya/cortx-utils that referenced this pull request Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants