This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
EOS-24098: Configure log directory #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Selvakumar <[email protected]>
selvakumaar5496
requested review from
ajaysrivas,
s-arya and
sachinpunadikar
as code owners
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
py-utils/src/setup/utils_setup.py
Outdated
| Conf.load('config_file', f'yaml:///{config_file_path}', skip_reload=True) | ||
| # Get the log path | ||
| log_dir = Conf.get('config_file', 'log_dir') | ||
| log_path = os.path.join(log_dir, 'cortx/utils') |
There was a problem hiding this comment.
log_path -> utils_log_path
Applicable at other places as well
|
Need to get the log_dir from passed in confstore (from provisioner / template file) in mini-provisioning. If this is not provided, there should be a default value |
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Rohit Dwivedi <[email protected]>
vastradparayya
approved these changes
Aug 31, 2021
py-utils/src/setup/utils_setup.py
Outdated
| config_file_path = '/etc/cortx/cortx.conf' | ||
| Conf.load('config_file', f'yaml:///{config_file_path}', skip_reload=True) | ||
| # Get the log path | ||
| log_dir = Conf.get('config_file', 'log_dir', '/var/log') |
There was a problem hiding this comment.
this should be read from passed in information (like populated template file)
There was a problem hiding this comment.
done in utils_setup config phase
There was a problem hiding this comment.
config phase will set the log_dir for rest of the code.
But utils_setup log will go to the default place (i.e. /var/log/..). Hence asking to get the required log directory here as well, and create log file for utils_setup in that directory.
sachinpunadikar
suggested changes
Aug 31, 2021
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
vastradparayya
pushed a commit
to vastradparayya/cortx-utils
that referenced
this pull request
Sep 1, 2021
* CORTX deployment on AWS Signed-off-by: Shailesh Vaidya <[email protected]> * Use $PWD Signed-off-by: Shailesh Vaidya <[email protected]> * Removed ssc-vm details Signed-off-by: Shailesh Vaidya <[email protected]> * Removed SSC VM details Signed-off-by: Shailesh Vaidya <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Selvakumar [email protected]
Problem Statement
Design
Coding
Testing
Review Checklist
Before posting the PR please ensure
Documentation