Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-24934: package validation restored in post_install phases #532

Conversation

rahul-tripathi-git
Copy link
Contributor

@rahul-tripathi-git rahul-tripathi-git commented Sep 16, 2021

Signed-off-by: Rahul Tripathi [email protected]

Problem Statement

  • Python packages should be validated in post_install

Design

  • The validation of correct python packages should be restored in both, utils rpm post_install as well as utils mini-prov post_install phase

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: Y
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: Y
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

jenkins/build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on the comment

Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit bbc1016 into Seagate:kubernetes Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants