This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
EOS-25060: Update cluster.conf to iem.conf #538
Merged
sachinpunadikar
merged 16 commits into
Seagate:kubernetes
from
selvakumaar5496:update_conf
Sep 28, 2021
Merged
EOS-25060: Update cluster.conf to iem.conf #538
sachinpunadikar
merged 16 commits into
Seagate:kubernetes
from
selvakumaar5496:update_conf
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Selvakumar <[email protected]>
selvakumaar5496
requested review from
ajaysrivas,
s-arya and
sachinpunadikar
as code owners
September 25, 2021 11:08
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
selvakumaar5496
changed the title
update cluster.conf to iem.conf
EOS-25060: Update cluster.conf to iem.conf
Sep 27, 2021
selvakumaar5496
commented
Sep 27, 2021
""" Create the config file required for Event Message """ | ||
for key, value in server_info.items(): | ||
Conf.set('cluster', f'node>{key}', value) | ||
Conf.set('cluster', 'site_id', '1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directly setting it to 1 does not make any sense
selvakumaar5496
commented
Sep 27, 2021
sachinpunadikar
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
sachinpunadikar
force-pushed
the
kubernetes
branch
from
September 28, 2021 07:19
1c053dc
to
58ec4e3
Compare
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
Signed-off-by: Selvakumar <[email protected]>
rahul-tripathi-git
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Signed-off-by: Selvakumar <[email protected]>
sachinpunadikar
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Selvakumar [email protected]
Problem Statement
Design
Coding
Testing
Review Checklist
Before posting the PR please ensure
Documentation