Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-25060: Update cluster.conf to iem.conf #538

Merged
merged 16 commits into from
Sep 28, 2021
Merged

EOS-25060: Update cluster.conf to iem.conf #538

merged 16 commits into from
Sep 28, 2021

Conversation

selvakumaar5496
Copy link
Contributor

@selvakumaar5496 selvakumaar5496 commented Sep 25, 2021

Signed-off-by: Selvakumar [email protected]

Problem Statement

Design

  • Create module specific configurations

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@selvakumaar5496 selvakumaar5496 changed the title update cluster.conf to iem.conf EOS-25060: Update cluster.conf to iem.conf Sep 27, 2021
""" Create the config file required for Event Message """
for key, value in server_info.items():
Conf.set('cluster', f'node>{key}', value)
Conf.set('cluster', 'site_id', '1')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directly setting it to 1 does not make any sense

Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@rahul-tripathi-git rahul-tripathi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Selvakumar <[email protected]>
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit 9c83108 into Seagate:kubernetes Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants