Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-25112: Make iem.conf path configurable #554

Merged
merged 2 commits into from
Oct 1, 2021
Merged

EOS-25112: Make iem.conf path configurable #554

merged 2 commits into from
Oct 1, 2021

Conversation

selvakumaar5496
Copy link
Contributor

@selvakumaar5496 selvakumaar5496 commented Oct 1, 2021 •
edited
Loading

Signed-off-by: Selvakumar [email protected]

Problem Statement

Design

  • Make iem.conf path configurable from cortx>common>storage>local

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

sachinpunadikar
sachinpunadikar reviewed Oct 1, 2021
View reviewed changes
py-utils/src/utils/iem_framework/event_message.py Outdated
_conf_file = 'json:///etc/cortx/cluster.conf'
local_storage = CortxConf.get_storage_path('local')
iem_conf = os.path.join(local_storage, 'utils/conf/iem.conf')
conf_file = f'json://{iem_conf}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be _conf_file ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@selvakumaar5496
change the variable name
f64b31a 
Signed-off-by: Selvakumar <[email protected]>
sachinpunadikar
sachinpunadikar approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@selvakumaar5496 selvakumaar5496 changed the title Make iem.conf path configurable EOS-25112: Make iem.conf path configurable Oct 1, 2021
@sachinpunadikar sachinpunadikar merged commit 3ee9cd3 into Seagate:kubernetes Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@vastradparayya vastradparayya vastradparayya approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@s-arya s-arya Awaiting requested review from s-arya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@selvakumaar5496 @sachinpunadikar @vastradparayya @rohit-k-dwivedi