Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-25313: SSL certificate generation check-in #578

Merged
merged 10 commits into from
Oct 19, 2021
Merged

EOS-25313: SSL certificate generation check-in #578

merged 10 commits into from
Oct 19, 2021

Conversation

rohitkolapkar
Copy link
Contributor

@rohitkolapkar rohitkolapkar commented Oct 11, 2021

Problem Statement

Write a utility in pyutils to generate a self signed ssl certificate.
CSM Agent use case: If csm_agent protocol is 'https' and during csm mini provisioning, ssl_certificate is not present at specified path then csm will call this utility to generate and store a self signed ssl certificate.

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: N
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

rohitkolapkar added 2 commits October 11, 2021 09:35
@welcome
Copy link

welcome bot commented Oct 11, 2021

Thanks for your contribution in opening this pull request! Now you can be rewarded with a CORTX sticker by requesting cortx sticker
In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

Copy link
Contributor

@pawankumarsrivastava pawankumarsrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redefine class as per discussion

py-utils/src/utils/security/ssl_cert.py Outdated Show resolved Hide resolved
py-utils/src/utils/security/ssl_cert.py Outdated Show resolved Hide resolved
py-utils/src/utils/security/ssl_cert.py Outdated Show resolved Hide resolved
py-utils/src/utils/security/ssl_cert.py Outdated Show resolved Hide resolved
py-utils/src/utils/security/ssl_cert.py Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Oct 18, 2021

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @s-arya @sachinpunadikar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

Copy link
Contributor

@pawankumarsrivastava pawankumarsrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix codacy issues

py-utils/src/utils/security/certificate.py Outdated Show resolved Hide resolved
py-utils/src/utils/security/certificate.py Outdated Show resolved Hide resolved
py-utils/src/utils/security/certificate.py Outdated Show resolved Hide resolved
@pawankumarsrivastava
Copy link
Contributor

Please add an example of how to use the Certificate class

rohitkolapkar added 2 commits October 19, 2021 03:15
@rohitkolapkar
Copy link
Contributor Author

Added an example for how to use Certificate class.
@pawankumarsrivastava

Signed-off-by: rohitkolapkar <[email protected]>
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit c8bde0f into Seagate:kubernetes Oct 19, 2021
@welcome
Copy link

welcome bot commented Oct 19, 2021

Thanks for your contribution to CORTX! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants