Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Enhanced Utils Support Bundle CLI to take Cluster.conf as input #590

Merged
merged 7 commits into from
Oct 18, 2021
Merged

Enhanced Utils Support Bundle CLI to take Cluster.conf as input #590

merged 7 commits into from
Oct 18, 2021

Conversation

suryakumar1024
Copy link
Contributor

@suryakumar1024 suryakumar1024 commented Oct 14, 2021 •
edited
Loading

Problem Statement

  • Added -c for accepting cluster.conf and -s for accepting services as an argument to Support bundle cli.

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@suryakumar1024
Updated utils support bundle to take cluster.conf as input -c
faaf73c 
Added IEM, MessageBus, Cortx conf into SB

Signed-off-by: suryakumar.kumaravelan <[email protected]>
@suryakumar1024
Updated utils support bundle to take cluster.conf as input -c
9588443 
Added IEM, MessageBus, Cortx conf into SB

Signed-off-by: suryakumar.kumaravelan <[email protected]>
@suryakumar1024
Merge branch 'sb_utils' of https://github.com/Seagate/cortx-utils int…
87a95dc 
…o sb_utils

Signed-off-by: suryakumar.kumaravelan <[email protected]>

Conflicts:
	py-utils/src/support/utils_support_bundle.py
@suryakumar1024
Merge branch 'sb_utils' of https://github.com/Seagate/cortx-utils int…
1202bae 
…o sb_utils

Signed-off-by: suryakumar.kumaravelan <[email protected]>

Conflicts:
	py-utils/src/support/utils_support_bundle.py
@suryakumar1024
Merge branch 'sb_utils' of https://github.com/Seagate/cortx-utils int…
1f0f18b 
…o sb_utils

Signed-off-by: suryakumar.kumaravelan <[email protected]>

Conflicts:
	py-utils/src/support/utils_support_bundle.py
@suryakumar1024 suryakumar1024 mentioned this pull request Oct 14, 2021
Closed
12 tasks
@suryakumar1024
Code optimize
512ae4c 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
rohit-k-dwivedi
rohit-k-dwivedi reviewed Oct 18, 2021
View reviewed changes
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logically looks good, but added some cosmetic comments, please word on that

rohit-k-dwivedi
rohit-k-dwivedi approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logically looks good, but added some cosmetic comments, please word on that

sachinpunadikar
sachinpunadikar suggested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on the comments

@suryakumar1024
Code optimize
2096549 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
sachinpunadikar
sachinpunadikar approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

vastradparayya
vastradparayya approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@vastradparayya vastradparayya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachinpunadikar sachinpunadikar merged commit 11d5efa into Seagate:kubernetes Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@vastradparayya vastradparayya vastradparayya approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@selvakumaar5496 selvakumaar5496 Awaiting requested review from selvakumaar5496

@rahul-tripathi-git rahul-tripathi-git Awaiting requested review from rahul-tripathi-git

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@s-arya s-arya Awaiting requested review from s-arya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryakumar1024 @sachinpunadikar @vastradparayya @rohit-k-dwivedi