Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-25148: Generate support Bundle inside K8s env. #593

Merged
merged 15 commits into from
Oct 19, 2021
Merged

EOS-25148: Generate support Bundle inside K8s env. #593

merged 15 commits into from
Oct 19, 2021

Conversation

gargpalak048
Copy link
Contributor

@gargpalak048 gargpalak048 commented Oct 17, 2021 •
edited
Loading

Problem Statement

  • Generate support Bundle inside K8s env.

Design

-Finalized Design for SB generation:
https://seagate-systems.atlassian.net/wiki/spaces/PUB/pages/749076684/Node+level+Support+Bundle+Collection

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • [Y] Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • [] All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

@gargpalak048 gargpalak048 changed the title Generate support Bundle inside K8s env. EOS-25148: Generate support Bundle inside K8s env. Oct 17, 2021
cdeshmukh
cdeshmukh suggested changes Oct 18, 2021
View reviewed changes
py-utils/src/support/cortx_support_bundle.py Show resolved Hide resolved
py-utils/src/support/cortx_support_bundle.py Show resolved Hide resolved
py-utils/src/utils/support_framework/bundle.py Show resolved Hide resolved
py-utils/src/utils/support_framework/bundle_generate.py Show resolved Hide resolved
py-utils/src/utils/support_framework/bundle_generate.py Show resolved Hide resolved
py-utils/src/utils/support_framework/bundle_generate.py Show resolved Hide resolved
py-utils/src/utils/support_framework/bundle_generate.py Show resolved Hide resolved
py-utils/src/utils/support_framework/bundle_generate.py Show resolved Hide resolved
py-utils/src/utils/support_framework/support_bundle.py Outdated Show resolved Hide resolved
py-utils/src/utils/support_framework/support_bundle.py Outdated Show resolved Hide resolved
sachinpunadikar
sachinpunadikar suggested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why default path for cluster.conf is in use? Path for this file is already provided as an input

@gargpalak048
Copy link
Contributor Author

gargpalak048 commented Oct 19, 2021 •
edited
Loading

Why default path for cluster.conf is in use? Path for this file is already provided as an input

If config url is not parsed as an user input, it will use default config.
check #L47 in cortx_support_bundle.py

@gargpalak048
EOS-25148: Generate support Bundle inside K8s env.
dd8d0b4 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Fix Code Issues
fd35d74 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Addressed review comments
cfcbfda 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Fix Codacy Issues
28d4d5c 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Use Log object instead of publish_logs function
2cae7e5 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Addressed review comments
002d739 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Addressed review comments
16fb147 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Addressed review comments
a171d5f 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Fix Codacy Issues
f12e575 
Signed-off-by: Palak Garg <[email protected]>
@gargpalak048
Addressed review comment
e93ee69 
Signed-off-by: Palak Garg <[email protected]>
vastradparayya
vastradparayya suggested changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@vastradparayya vastradparayya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test cases

sachinpunadikar
sachinpunadikar approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit 8f50c1c into Seagate:kubernetes Oct 19, 2021
@cdeshmukh cdeshmukh mentioned this pull request Oct 21, 2021
Merged
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@satish-seagate satish-seagate satish-seagate approved these changes

@vastradparayya vastradparayya vastradparayya approved these changes

@cdeshmukh cdeshmukh cdeshmukh approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@s-arya s-arya Awaiting requested review from s-arya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gargpalak048 @sachinpunadikar @cdeshmukh @vastradparayya @satish-seagate