Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-26021: S3 Audit Log: Expose an API to push audit logs #633

Merged
merged 6 commits into from
Dec 13, 2021
Merged

EOS-26021: S3 Audit Log: Expose an API to push audit logs #633

merged 6 commits into from
Dec 13, 2021

Conversation

vastradparayya
Copy link
Contributor

@vastradparayya vastradparayya commented Dec 7, 2021 •
edited
Loading

Problem Statement

  • S3 Audit Log: Expose an API to push audit logs

Design

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: Y
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: Y
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: N
  • If yes for above point, Is a notification sent to all other cortx components [Y/N] NA
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@vastradparayya vastradparayya changed the title EOS-26021: S3 Audit Log: Expose an API to push audit logs WIP - EOS-26021: S3 Audit Log: Expose an API to push audit logs Dec 7, 2021
@vastradparayya vastradparayya changed the title WIP - EOS-26021: S3 Audit Log: Expose an API to push audit logs EOS-26021: S3 Audit Log: Expose an API to push audit logs Dec 8, 2021
@vastradparayya
Adding audit log server
3e805ce 
Signed-off-by: Parayya Vastrad <[email protected]>
@vastradparayya
Codacy issues
5daae7a 
Signed-off-by: Parayya Vastrad <[email protected]>
@vastradparayya
For error.pt makes use of UtilsError
5fc1a0e 
Signed-off-by: Parayya Vastrad <[email protected]>
@vastradparayya
AuditLogError
454ec0c 
Signed-off-by: Parayya Vastrad <[email protected]>
sachinpunadikar
sachinpunadikar approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rohit-k-dwivedi
rohit-k-dwivedi approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rahul-tripathi-git
rahul-tripathi-git approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@rahul-tripathi-git rahul-tripathi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

selvakumaar5496
selvakumaar5496 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@selvakumaar5496 selvakumaar5496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachinpunadikar sachinpunadikar merged commit 4b50332 into Seagate:kubernetes Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@rahul-tripathi-git rahul-tripathi-git rahul-tripathi-git approved these changes

@selvakumaar5496 selvakumaar5496 selvakumaar5496 approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vastradparayya @sachinpunadikar @selvakumaar5496 @rahul-tripathi-git @rohit-k-dwivedi