This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
EOS-27087:Version compatibility check. #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shriya-deshmukh
requested review from
ajaysrivas and
sachinpunadikar
as code owners
January 3, 2022 14:00
ujjwalpl
suggested changes
Jan 3, 2022
ujjwalpl
suggested changes
Jan 3, 2022
Signed-off-by: Shriya Deshmukh <[email protected]>
Signed-off-by: Shriya Deshmukh <[email protected]>
shriya-deshmukh
force-pushed
the
EOS-27087
branch
from
January 4, 2022 05:11
c71c6e5
to
f473253
Compare
ujjwalpl
suggested changes
Jan 4, 2022
ujjwalpl
suggested changes
Jan 4, 2022
ujjwalpl
suggested changes
Jan 4, 2022
ujjwalpl
suggested changes
Jan 4, 2022
Signed-off-by: Shriya Deshmukh <[email protected]>
ujjwalpl
approved these changes
Jan 4, 2022
Signed-off-by: Shriya Deshmukh <[email protected]>
sachinpunadikar
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, rest all looks good
Signed-off-by: Shriya Deshmukh <[email protected]>
suryakumar1024
pushed a commit
to suryakumar1024/cortx-utils
that referenced
this pull request
Mar 21, 2022
* EOS-27087:Version compatibilty check Signed-off-by: Shriya Deshmukh <[email protected]> * Addressed review comments. Signed-off-by: Shriya Deshmukh <[email protected]> * Modify Manifest class. Signed-off-by: Shriya Deshmukh <[email protected]> * fixed codacy issue. Signed-off-by: Shriya Deshmukh <[email protected]> * addressed review comment. Signed-off-by: Shriya Deshmukh <[email protected]> Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shriya Deshmukh [email protected]
Problem Statement
Design
Coding
Testing
Review Checklist
Before posting the PR please ensure
Documentation