Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27087:Version compatibility check. #684

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

shriya-deshmukh
Copy link
Contributor

@shriya-deshmukh shriya-deshmukh commented Jan 3, 2022

Signed-off-by: Shriya Deshmukh [email protected]

Problem Statement

  • Problem statement

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

py-utils/src/utils/schema/release.py Outdated Show resolved Hide resolved
py-utils/src/utils/schema/release.py Outdated Show resolved Hide resolved
py-utils/src/utils/schema/release.py Outdated Show resolved Hide resolved
py-utils/src/utils/schema/release.py Outdated Show resolved Hide resolved
py-utils/src/utils/schema/release.py Outdated Show resolved Hide resolved
py-utils/src/utils/schema/release.py Outdated Show resolved Hide resolved
Signed-off-by: Shriya Deshmukh <[email protected]>
Signed-off-by: Shriya Deshmukh <[email protected]>
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, rest all looks good

Signed-off-by: Shriya Deshmukh <[email protected]>
@sachinpunadikar sachinpunadikar merged commit c3d1190 into Seagate:main Jan 5, 2022
suryakumar1024 pushed a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
* EOS-27087:Version compatibilty check

Signed-off-by: Shriya Deshmukh <[email protected]>

* Addressed review comments.

Signed-off-by: Shriya Deshmukh <[email protected]>

* Modify Manifest class.

Signed-off-by: Shriya Deshmukh <[email protected]>

* fixed codacy issue.

Signed-off-by: Shriya Deshmukh <[email protected]>

* addressed review comment.

Signed-off-by: Shriya Deshmukh <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants