Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27255: IEM CLI integration with Event message #690

Merged
merged 14 commits into from
Jan 7, 2022
Merged

EOS-27255: IEM CLI integration with Event message #690

merged 14 commits into from
Jan 7, 2022

Conversation

suryakumar1024
Copy link
Contributor

@suryakumar1024 suryakumar1024 commented Jan 7, 2022 •
edited
Loading

Problem Statement

  • New EventMessage init api takes message server endpoints and cluster_id as params.
  • Need to update Existing IEM CLI to pass the required params to EventMessage.init() api.

Design

  • Updated Existing code so as to pass required Message server endpoints and cluster_id as arguments.
  • No Change in IEM CLI signature.
  • Required Message server endpoints and clister_id details will be identiffied from the inputed file path (cluster.conf file).

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: N
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: N
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: N
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]: NA
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

selvakumaar5496 and others added 9 commits December 14, 2021 15:49
@selvakumaar5496
Fix init phase of Miniprovisioning (Seagate#645)
4f020da 
* Fix init phase of Miniprovisioning

Signed-off-by: Selvakumar <[email protected]>

* Fix test cases related to message_bus

Signed-off-by: Selvakumar <[email protected]>

* Remove creation of config files

Signed-off-by: Selvakumar <[email protected]>
@selvakumaar5496
Make use of components logger (Seagate#650)
c952b35 
* Make use of components logger

Signed-off-by: Selvakumar <[email protected]>

* Use utils logger if initialised

Signed-off-by: Selvakumar <[email protected]>
@selvakumaar5496
Ignore logging in message_bus if logger is not initialised (Seagate#652)
767baec 
* Ignore logging if logger is not initialised

Signed-off-by: Selvakumar <[email protected]>

* Ignore logging if logger is not initialised

Signed-off-by: Selvakumar <[email protected]>
@veerendra-simha-garikipati
Updated message_bus tests to take cluster.conf path as input and get …
579910f 
…kafka endpoints from conf. (Seagate#658)
@rohit-k-dwivedi
PATCH: update PyYaml version
31917e5 
Signed-off-by: Rohit Dwivedi <[email protected]>
@selvakumaar5496
Merge pull request Seagate#671 from rohit-k-dwivedi/PATCH_PyYaml
6d153e9 
PATCH: update PyYaml version
@suryakumar1024 @selvakumaar5496
EOS-25893: Implement init method for Event_message (Seagate#670)
da98dce 
* Iem prep and messagebus init changes

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Update event_message.py

* Update event_message.py

* Update event_message.py

* Update test_iem.py

* Update event_message.py

* Update test_iem.py

* Update event_message.py

Co-authored-by: Sachin Punadikar <[email protected]>
Co-authored-by: Selva Nambi <[email protected]>
@suryakumar1024
iem cli changes no conf
57851a2 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
@suryakumar1024
reverted iem patch for optional arguments
a24bf61 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
@suryakumar1024
Iem Fix for Event message chagnes
a5bdadc 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
@suryakumar1024 suryakumar1024 changed the title WIP: EOS-27255: IEM CLI integration with Event message EOS-27255: IEM CLI integration with Event message Jan 7, 2022
@sachinpunadikar sachinpunadikar changed the base branch from utils_no_conf to main January 7, 2022 09:54
@sachinpunadikar sachinpunadikar changed the base branch from main to utils_no_conf_merged January 7, 2022 09:55
@sachinpunadikar sachinpunadikar changed the base branch from utils_no_conf_merged to main January 7, 2022 10:03
sachinpunadikar
sachinpunadikar approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@suryakumar1024
Code optimize
9f99ba6 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
@sachinpunadikar
Copy link
Contributor

test this please

@suryakumar1024 suryakumar1024 reopened this Jan 7, 2022
@suryakumar1024
Copy link
Contributor Author

Re-tested this patch after rebase..

@suryakumar1024
Copy link
Contributor Author

suryakumar1024 commented Jan 7, 2022 •
edited
Loading

test this please

Test success.

[root@ssc-vm-g2-rhev4-2547 iem_framework]# python3 test_iem_cli.py
.......

Ran 7 tests in 27.446s

OK

@sachinpunadikar
Copy link
Contributor

retested the k8s build, its success
http://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Cortx-Deployment/job/Kubernetes/job/py-utils/24/

@sachinpunadikar sachinpunadikar merged commit 5fa32ec into Seagate:main Jan 7, 2022
@sachinpunadikar sachinpunadikar deleted the iem_cli_noconf branch January 7, 2022 13:10
suryakumar1024 added a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
@suryakumar1024 @selvakumaar5496
@veerendra-simha-garikipati @rohit-k-dwivedi
EOS-27255: IEM CLI integration with Event message (Seagate#690)
9f6d5fc 
* Fix init phase of Miniprovisioning (Seagate#645)

* Fix init phase of Miniprovisioning

Signed-off-by: Selvakumar <[email protected]>

* Fix test cases related to message_bus

Signed-off-by: Selvakumar <[email protected]>

* Remove creation of config files

Signed-off-by: Selvakumar <[email protected]>

* Make use of components logger (Seagate#650)

* Make use of components logger

Signed-off-by: Selvakumar <[email protected]>

* Use utils logger if initialised

Signed-off-by: Selvakumar <[email protected]>

* Ignore logging in message_bus if logger is not initialised (Seagate#652)

* Ignore logging if logger is not initialised

Signed-off-by: Selvakumar <[email protected]>

* Ignore logging if logger is not initialised

Signed-off-by: Selvakumar <[email protected]>

* Updated message_bus tests to take cluster.conf path as input and get kafka endpoints from conf. (Seagate#658)

* PATCH: update PyYaml version

Signed-off-by: Rohit Dwivedi <[email protected]>

* EOS-25893: Implement init method for Event_message (Seagate#670)

* Iem prep and messagebus init changes

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Update event_message.py

* Update event_message.py

* Update event_message.py

* Update test_iem.py

* Update event_message.py

* Update test_iem.py

* Update event_message.py

Co-authored-by: Sachin Punadikar <[email protected]>
Co-authored-by: Selva Nambi <[email protected]>

* iem cli changes no conf

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* reverted iem patch for optional arguments

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Iem Fix for Event message chagnes

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Update iem_cli.py

* Code optimize

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Update iem_cli.py

Co-authored-by: Selva Nambi <[email protected]>
Co-authored-by: veerendra-simha-garikipati <[email protected]>
Co-authored-by: Rohit Dwivedi <[email protected]>
Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@selvakumaar5496 selvakumaar5496 selvakumaar5496 approved these changes

@vastradparayya vastradparayya vastradparayya approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@rahul-tripathi-git rahul-tripathi-git Awaiting requested review from rahul-tripathi-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@suryakumar1024 @sachinpunadikar @vastradparayya @selvakumaar5496 @rohit-k-dwivedi @veerendra-simha-garikipati