Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27350: Utils_setup reset and cleanup phases are failing #703

Merged
merged 5 commits into from
Jan 17, 2022
Merged

EOS-27350: Utils_setup reset and cleanup phases are failing #703

merged 5 commits into from
Jan 17, 2022

Conversation

suryakumar1024
Copy link
Contributor

@suryakumar1024 suryakumar1024 commented Jan 11, 2022 •
edited
Loading

Signed-off-by: suryakumar.kumaravelan [email protected]

Problem Statement

  • Utils_setup reset and cleanup phases are failing due to messagebus config not loaded exception.

Design

  • Added MessageBus init api code to both the phases.

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: NA
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: N
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: N
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]: NA
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@suryakumar1024
Utils mini provisioning fix
2999399 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
sachinpunadikar
sachinpunadikar approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit 9dc2e0c into Seagate:main Jan 17, 2022
@sachinpunadikar sachinpunadikar deleted the utils_mp_fix branch January 17, 2022 06:09
suryakumar1024 added a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
@suryakumar1024
EOS-27350: Utils_setup reset and cleanup phases are failing (Seagate#703
3566477 
)

* Utils mini provisioning fix

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Code optimize and purge changes

Signed-off-by: suryakumar.kumaravelan <[email protected]>

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@selvakumaar5496 selvakumaar5496 selvakumaar5496 approved these changes

@vastradparayya vastradparayya vastradparayya approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ujjwalpl ujjwalpl ujjwalpl approved these changes

@rahul-tripathi-git rahul-tripathi-git Awaiting requested review from rahul-tripathi-git

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@suryakumar1024 @ujjwalpl @sachinpunadikar @vastradparayya @selvakumaar5496 @rohit-k-dwivedi