Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27344: update template files for miniprovisioning #707

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

rohit-k-dwivedi
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi commented Jan 13, 2022

Signed-off-by: Rohit Dwivedi [email protected]

Problem Statement

  • Update template files for miniprovisioning

Design

  • Introduced a single template file with all keys for all steps, only the keys mentioned in each phase in wiki , needs to be updated for each individual phase

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@rohit-k-dwivedi rohit-k-dwivedi force-pushed the EOS-27344 branch 2 times, most recently from a3dcadd to 8641b59 Compare January 17, 2022 11:57
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rohit-k-dwivedi rohit-k-dwivedi changed the title WIP: EOS-27344: update template files for miniprovisioning EOS-27344: update template files for miniprovisioning Jan 17, 2022
@sachinpunadikar sachinpunadikar merged commit b7c8878 into Seagate:main Jan 18, 2022
suryakumar1024 pushed a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
Signed-off-by: Rohit Dwivedi <[email protected]>

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants